New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make adhoc include_role/task work again! #49247

Merged
merged 4 commits into from Dec 10, 2018

Conversation

Projects
None yet
4 participants
@bcoca
Member

bcoca commented Nov 28, 2018

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

bin/ansible
include_role
include_tasks

@sivel

This comment has been minimized.

Member

sivel commented Nov 28, 2018

Do you think we should pass along async_val if it was non-zero? In case a user tried to run the include with async it would return an error instead of being silently ignored?

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 28, 2018

Hi @bcoca, thank you for submitting this pull-request!

click here for bot help

@bcoca

This comment has been minimized.

Member

bcoca commented Nov 28, 2018

now i pass if set

Show resolved Hide resolved lib/ansible/cli/adhoc.py Outdated

@ansibot ansibot added core_review and removed needs_revision labels Nov 28, 2018

@samdoran samdoran removed the needs_triage label Dec 4, 2018

@gundalow gundalow changed the title from adhoc include_role/task work again! to make adhoc include_role/task work again! Dec 4, 2018

@bcoca bcoca merged commit 0c1f620 into ansible:devel Dec 10, 2018

1 check passed

Shippable Run 95888 status is SUCCESS.
Details

@bcoca bcoca deleted the bcoca:fix_adhoc_include_role branch Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment