New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old 'srtd' theme and references. #49289

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@Xaroth
Contributor

Xaroth commented Nov 29, 2018

SUMMARY

The webdocs still had the old (used until 2.4) 'srtd' theme in its tree, as well as references and other files that were no longer used.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

Docs

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 29, 2018

Hi @Xaroth, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 29, 2018

@acozine

This comment has been minimized.

Contributor

acozine commented Nov 30, 2018

I built this locally and looked at a few random pages. The formatting on Note and Warning sections doesn't look correct. For example:

Current docsite ACI Guide, Auth section:

screen shot 2018-11-30 at 3 31 24 pm

Local build from this branch, same page:

screen shot 2018-11-30 at 3 33 12 pm

@ansibot ansibot added docsite and removed needs_triage labels Nov 30, 2018

@acozine

This comment has been minimized.

Contributor

acozine commented Dec 1, 2018

After debugging with @Xaroth, discovered the issue above only happens when viewing the output via file:///path/to/_build/html/filename.html. If I run a local webserver (python -m SimpleHTTPServer) and view the files from localhost:port# I see the boxes for Note and Warning.

However, on the devel branch I get the boxes even with file:/// . . . unless that's something to do with caching. If anyone has time to test this, post updates on your experiences.

@ansibot ansibot added the stale_ci label Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment