New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate handler tracking #49338

Merged
merged 11 commits into from Dec 11, 2018

Conversation

Projects
None yet
4 participants
@sivel
Member

sivel commented Nov 29, 2018

SUMMARY

Consolidate handler tracking

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@sivel

This comment has been minimized.

Member

sivel commented Nov 29, 2018

bot_skip

@sivel sivel force-pushed the sivel:handler-tracking branch from a14d7df to 638f065 Nov 30, 2018

@sivel

This comment has been minimized.

Member

sivel commented Nov 30, 2018

@sivel sivel force-pushed the sivel:handler-tracking branch from 0e2a6db to 4751500 Dec 3, 2018

@sivel sivel changed the title from [WIP] Consolidate handler tracking to Consolidate handler tracking Dec 3, 2018

@sivel

This comment has been minimized.

Member

sivel commented Dec 5, 2018

The ci_complete run is failing on the 2 CloudStack targets, and seem to be unrelated.

@sivel sivel requested a review from s-hertel Dec 5, 2018

if listening_handler is not None:
found = True
else:
for target_handler_block in reversed(iterator._play.handlers):

This comment has been minimized.

@sivel

sivel Dec 6, 2018

Member

@s-hertel pointed out that this for loop may not be needed any more. I think I agree, likely due to the change in #49317

But we'll need to investigate more.

@bcoca bcoca merged commit 2a469fd into ansible:devel Dec 11, 2018

1 check passed

Shippable Run 97188 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment