New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add path info to role list #49346

Merged
merged 3 commits into from Dec 10, 2018

Conversation

Projects
None yet
4 participants
@bcoca
Member

bcoca commented Nov 30, 2018

  • use same display format for both listing all and specific roles
  • show warnings at end to allow selecting the output w/o interruption
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ansible-galaxy

ADDITIONAL INFORMATION

Before:

- test1, (unknown version)
 [WARNING]: - the configured path /usr/share/ansible/roles does not exist.

- geerlingguy.apache, 2.0.0
- test-1, (unknown version)
- test2, (unknown version)
- test1, (unknown version)

After:

# /home/bcoca/.ansible/roles
- test1, (unknown version)
# /etc/ansible/roles
- geerlingguy.apache, 2.0.0
- test-1, (unknown version)
- test2, (unknown version)
- test1, (unknown version)
 [WARNING]: - the configured path /usr/share/ansible/roles does not exist.

bcoca added some commits Nov 30, 2018

add path info to role list
 - use same display format for both listing all and specific roles
@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 30, 2018

Hi @bcoca, thank you for submitting this pull-request!

click here for bot help

Show resolved Hide resolved lib/ansible/cli/galaxy.py Outdated
Update lib/ansible/cli/galaxy.py
Co-Authored-By: bcoca <bcoca@users.noreply.github.com>
@bcoca

This comment has been minimized.

Member

bcoca commented Dec 1, 2018

ready_for_review

@ansibot ansibot added core_review and removed needs_revision labels Dec 1, 2018

@sivel sivel removed needs_triage labels Dec 4, 2018

@bcoca bcoca merged commit 42a13d1 into ansible:devel Dec 10, 2018

1 check passed

Shippable Run 96151 status is SUCCESS.
Details

@bcoca bcoca deleted the bcoca:nicer_role_list branch Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment