New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify vm_guest detection code #49378

merged 1 commit into from Dec 10, 2018


None yet
3 participants

bcoca commented Nov 30, 2018

  • remove a lot of repetition
  • Bugfix Pull Request

fact gathering


This comment has been minimized.


ansibot commented Nov 30, 2018

Hi @bcoca, thank you for submitting this pull-request!

click here for bot help

simplify vm_guest detection code
  - remove a lot of repetition
  - change lists to tuples since they are faster to assign

@bcoca bcoca force-pushed the bcoca:simpler_vm_guest_detect branch from a87b553 to 8fd40d8 Nov 30, 2018

@ansible ansible deleted a comment from ansibot Nov 30, 2018

@ansibot ansibot added the core_review label Nov 30, 2018

@samdoran samdoran removed the needs_triage label Dec 4, 2018

@bcoca bcoca merged commit e53a785 into ansible:devel Dec 10, 2018

1 check passed

Shippable Run 96214 status is SUCCESS.

@bcoca bcoca deleted the bcoca:simpler_vm_guest_detect branch Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment