New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws] Revert back to getting the AWS role name from the URI #49428

Merged
merged 2 commits into from Dec 10, 2018

Conversation

Projects
None yet
3 participants
@roadmapper
Contributor

roadmapper commented Dec 3, 2018

SUMMARY
  • The role name and instance profile name can be different, the change made in #45534 gets the instance profile name, not the role name
  • Change the delimiter to : for keys that are discovered through the JSON parsing (which is not a valid delimiter for AWS IAM role names), this delimiter is still converted to underscore
  • Now checks for the existence of that delimiter to remove the cases where the JSON keys are appended to the role name to find the role name

Actually fixes #45228

(cherry picked from commit ff9b86f)

Backport of #49113

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

roadmapper added some commits Nov 27, 2018

Revert back to getting the AWS role name from the URI with a small ch…
…ange (#49113)

- The role name and instance profile name _can_ be different
- Change the delimiter to `:` for keys that are discovered through the JSON parsing (which is not a valid delimiter for AWS IAM role names), this delimiter is still converted to underscore
- Now checks for the existence of that delimiter to remove the cases where the JSON keys are appended to the role name to find the role name

(cherry picked from commit ff9b86f)
@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 3, 2018

Hi @roadmapper, thank you for submitting this pull-request!

click here for bot help

@mattclay mattclay merged commit dcee72f into ansible:stable-2.6 Dec 10, 2018

1 check passed

Shippable Run 96320 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment