New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Trying to demonstrate a test setup bug. #49538

Closed
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@aknrdureegaesr
Contributor

aknrdureegaesr commented Dec 5, 2018

SUMMARY

My pull request #48416 keeps earning test failures that I'm doubtful it has rightfully earned. Therefore, I desire to test the sanity of the ansible tests. This "pull request" does that.

So this contains a comment-only commit on top of a recent commit from the devel-branch. If the devel branch is sane and the build environment is sane, this should pass the checks. If there is a problem in the checks or in the present devel branch, this "pull request" will expose the problem.

Later addition: It did expose a problem, see #49541.

If the build is currently flaky, this test might pass. If the build is smart to only run certain tests, depending on the change proposed, I'll need to refine. We'll see.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module-utils

ADDITIONAL INFORMATION

This is not a useful pull request that should be merged.

@aknrdureegaesr

This comment has been minimized.

Contributor

aknrdureegaesr commented Dec 5, 2018

"If a computer tries to be smart, you occasionally need to do weird stuff." D. Knuth writes something to this effect (regarding his very own TeX).

@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 5, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/common/file.py:137:1: E303 too many blank lines (3)

click here for bot help

@aknrdureegaesr aknrdureegaesr force-pushed the aknrdureegaesr:empty-commit-on-top-of-devel branch from a11dbdd to d7be1fc Dec 6, 2018

@aknrdureegaesr

This comment has been minimized.

Contributor

aknrdureegaesr commented Dec 7, 2018

This phoney PR has served its purpose and is no longer needed.

In a personal remark: I had envisioned to retrigger this again and triumphantly close this after the "no problems" verdict from the tests. But I have learned the hard way that other build problems are still in existence.

Good luck to the people who engage fixing those! Your doing a service to the entire community.

@aknrdureegaesr aknrdureegaesr deleted the aknrdureegaesr:empty-commit-on-top-of-devel branch Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment