New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blkid instead of udevadm when lsblk < 2.33 to gather fs uuids #49598

Closed
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
5 participants
@gfidente

gfidente commented Dec 6, 2018

SUMMARY

Sometimes udevadm takes more than 10 seconds to gather the device
informations, causing facts gathering to hit the default timeout.

This change tries to fix #43884 by replacing use of udevadm with
blkid, which collects a lot less informations but still provides
for a fs-independent way to gather a fs uuid.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module_utils

Use blkid instead of udevadm when lsblk < 2.33 to gather fs uuids
Sometimes udevadm takes more than 10 seconds to gather the device
informations, causing facts gathering to hit the default timeout.

This change tries to fix #43884 by replacing use of udevadm with
blkid, which collects a lot less informations but still provides
for a fs-independent way to gather a fs uuid.
@mkrizek

This comment has been minimized.

Contributor

mkrizek commented Dec 7, 2018

I recall I used udevadm for a reason. Doesn't blkid require root?

@gfidente

This comment has been minimized.

gfidente commented Dec 7, 2018

@mkrizek thanks for reviewing the change; both seem to work as non-root for me

@mkrizek

This comment has been minimized.

Contributor

mkrizek commented Dec 7, 2018

@mkrizek thanks for reviewing the change; both seem to work as non-root for me

I assume that is because you have that information cached. Try running blkid in a fresh session.

From man blkid on my machine (Fedora 29):

blkid reads information directly from devices and for non-root users it returns cached unverified information.

@mkrizek

As per the comment above.

@samdoran samdoran self-assigned this Dec 11, 2018

@samdoran samdoran removed the needs_triage label Dec 11, 2018

@bcoca

This comment has been minimized.

Member

bcoca commented Dec 11, 2018

this does not really fix the issue but tries to bypass by using different tools that won't always provide the same information in the same contexts. See original issue for proposed solution in comment.

@samdoran samdoran removed their assignment Dec 11, 2018

@gfidente

This comment has been minimized.

gfidente commented Dec 12, 2018

@bcoca closing

@gfidente gfidente closed this Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment