New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let submitters know component is 'best effort' #49619

merged 2 commits into from Dec 11, 2018


None yet
5 participants

bcoca commented Dec 6, 2018

  • Feature Pull Request

issue templates


Not sure if allowing to leave it empty is going to help us, because it is the path of least resistance. I would rather avoid the ansibot component comment if we find a match, but leave this as-is.

Also we carefully ensured that comments do not stretch multiple lines to avoid people adding information inside the comment. So I am not in favor of this.

@ansibot ansibot added needs_revision and removed core_review labels Dec 8, 2018

Show resolved Hide resolved changelogs/fragments/dontfearcomponents.yml Outdated
Show resolved Hide resolved .github/ Outdated

@gundalow gundalow merged commit f8685e4 into ansible:devel Dec 11, 2018

1 check passed

Shippable Run 97527 status is SUCCESS.

This comment has been minimized.


gundalow commented Dec 11, 2018

Merged, this is better than it was.

@bcoca bcoca deleted the bcoca:dont_fear_component branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment