New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker_network_facts] Creating docker_network_facts module #49644

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
4 participants
@DBendit
Contributor

DBendit commented Dec 7, 2018

SUMMARY

Allows to retrieve facts on a docker network. Allows to determine whether it exists, and if it does, provides the output of docker network inspect (obtained via API) in the result.

Part of #49267

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

docker_network_facts

ADDITIONAL INFORMATION

Integration tests passing with ansible-test integration -v docker_network_facts --docker ubuntu1604 and ansible-test integration -v docker_network --docker ubuntu1604

And to answer the inevitable question of why it requires API v1.21 instead of 1.20, 1.21 is the first version where the API docs list a Networks section at all.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 7, 2018

@agronholm @akshay196 @cove @danihodovic @dariko @dusdanig @joshuaconner @jwitko @kassiansun @keitwb @olsaki @softzilla @tbouvet @ushuz @zfil

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot removed the needs_triage label Dec 7, 2018

@DBendit DBendit force-pushed the DBendit:docker_network_facts branch from 51ad80b to 163d93a Dec 8, 2018

@DBendit

This comment has been minimized.

Contributor

DBendit commented Dec 8, 2018

Alright, cleaned it up a bit. It was mostly a copy and paste job from get_container(), so that should probably get some love as well.

ready_for_review

@felixfontein

This comment has been minimized.

Contributor

felixfontein commented Dec 8, 2018

Yeah, get_container() would benefit from some cleaning-up as well :)

@felixfontein

shipit

@felixfontein

shipit

@DBendit DBendit force-pushed the DBendit:docker_network_facts branch from 8195103 to 2268551 Dec 9, 2018

@DBendit

This comment has been minimized.

Contributor

DBendit commented Dec 9, 2018

Changelog fragment removed and added some additional formatting to the documentation to match #49692

ready_for_review

@felixfontein

LGTM

@ansibot ansibot added shipit and removed community_review labels Dec 9, 2018

@felixfontein

This comment has been minimized.

Contributor

felixfontein commented Dec 9, 2018

The failed tests are unrelated to the PR; I've asked on #ansible-devel if someone can restart them.

@ansibot ansibot added needs_revision and removed shipit labels Dec 9, 2018

@DBendit DBendit closed this Dec 9, 2018

@DBendit DBendit reopened this Dec 9, 2018

@ansibot ansibot added shipit and removed needs_revision labels Dec 9, 2018

@willthames willthames merged commit f545763 into ansible:devel Dec 10, 2018

1 check passed

Shippable Run 97353 status is SUCCESS.
Details
@willthames

This comment has been minimized.

Contributor

willthames commented Dec 10, 2018

Merged. Thanks @DBendit for the new module, and thanks @felixfontein for the review

@DBendit

This comment has been minimized.

Contributor

DBendit commented Dec 10, 2018

@willthames Thank you for the merge!
@felixfontein Thank you for the review!

@DBendit DBendit deleted the DBendit:docker_network_facts branch Dec 10, 2018

@felixfontein

This comment has been minimized.

Contributor

felixfontein commented Dec 10, 2018

@DBendit thanks for reviewing!
@willthames thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment