New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewite of na_ontap_cifs to use NetAppModule, new options, and unit tests. #49782

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@carchi8py
Copy link
Contributor

carchi8py commented Dec 11, 2018

SUMMARY
  • Rewrite to use NetAppModule
  • New options share_properties, symlink_properties
  • Unit Tests
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 11, 2018

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

test/units/modules/storage/netapp/test_na_ontap_cifs.py:78:32: duplicate-key Duplicate key 'cifs-share-properties' in dictionary
test/units/modules/storage/netapp/test_na_ontap_cifs.py:80:34: duplicate-key Duplicate key 'cifs-share-symlink-properties' in dictionary

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 10, 2019

@carchi8py this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@carchi8py carchi8py force-pushed the carchi8py:netapp-1040 branch from 8b6de5d to f6e24fa Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment