New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint host #49936

Merged
merged 6 commits into from Jan 10, 2019

Conversation

@rcarrillocruz
Copy link
Contributor

rcarrillocruz commented Dec 14, 2018

SUMMARY

Checkpoint host

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

checkpoint_host

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 14, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:93:12: unnecessary-pass Unnecessary pass statement

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 723, in <module>
    main()
  File "../bin/plugin_formatter.py", line 681, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 296, in get_plugin_info
    if 'options' in doc and doc['options'] is None:
TypeError: argument of type 'NoneType' is not iterable
make: *** [modules] Error 1

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test pep8 [explain] failed with 10 errors:

lib/ansible/module_utils/network/checkpoint/checkpoint.py:29:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/checkpoint/checkpoint.py:32:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_host.py:18:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_host.py:29:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_host.py:40:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_host.py:45:15: E124 closing bracket does not match visual indentation
lib/ansible/modules/network/checkpoint/checkpoint_host.py:51:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_host.py:54:7: E271 multiple spaces after keyword
lib/ansible/modules/network/checkpoint/checkpoint_host.py:58:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_host.py:98:1: E305 expected 2 blank lines after class or function definition, found 0

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Dec 14, 2018

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 14, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 723, in <module>
    main()
  File "../bin/plugin_formatter.py", line 681, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 296, in get_plugin_info
    if 'options' in doc and doc['options'] is None:
TypeError: argument of type 'NoneType' is not iterable
make: *** [modules] Error 1

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/module_utils/network/checkpoint/checkpoint.py:29:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/checkpoint/checkpoint.py:32:1: E302 expected 2 blank lines, found 1

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 19, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 749, in <module>
    main()
  File "../bin/plugin_formatter.py", line 704, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 316, in get_plugin_info
    if 'options' in doc and doc['options'] is None:
TypeError: argument of type 'NoneType' is not iterable
make: *** [modules] Error 1

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/module_utils/network/checkpoint/checkpoint.py:29:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/checkpoint/checkpoint.py:32:1: E302 expected 2 blank lines, found 1

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 19, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 749, in <module>
    main()
  File "../bin/plugin_formatter.py", line 704, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 316, in get_plugin_info
    if 'options' in doc and doc['options'] is None:
TypeError: argument of type 'NoneType' is not iterable
make: *** [modules] Error 1

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:8:0: ImportError: No module named checkpoint.checkpoint

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:8:0: ImportError: No module named 'ansible.module_utils.network.checkpoint'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:8:0: ModuleNotFoundError: No module named 'ansible.module_utils.network.checkpoint'

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:8:0: ImportError: No module named checkpoint.checkpoint

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:8:0: ModuleNotFoundError: No module named 'ansible.module_utils.network.checkpoint'

click here for bot help

@ansibot ansibot added the stale_ci label Dec 27, 2018

@abenokraitis abenokraitis added this to Needs Triage in Networking via automation Jan 8, 2019

@ansibot ansibot added the needs_rebase label Jan 8, 2019

@rcarrillocruz rcarrillocruz force-pushed the rcarrillocruz:checkpoint_host branch from 56613ca to bae79f7 Jan 9, 2019

@rcarrillocruz rcarrillocruz force-pushed the rcarrillocruz:checkpoint_host branch from bae79f7 to 19e608e Jan 9, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 9, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: E322 "state" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/network/checkpoint/checkpoint_host.py:0:0: E324 Value for "default" from the argument_spec ('present') for "state" does not match the documentation (None)

click here for bot help

@ansibot ansibot removed the support:network label Jan 9, 2019

@samccann
Copy link
Contributor

samccann left a comment

some minor doc suggestions.

module: checkpoint_host
short_description: Manages host objects on Checkpoint over Web Services API
description:
- Manages host objects on Checkpoint devices including creating, updating, removing access rules objects,

This comment has been minimized.

@samccann

samccann Jan 9, 2019

Contributor
Suggested change Beta
- Manages host objects on Checkpoint devices including creating, updating, removing access rules objects,
- Manages host objects on Checkpoint devices including creating, updating, removing access rules objects.
ip_address:
description:
- IP address of the host object.
type: str

This comment has been minimized.

@samccann

samccann Jan 9, 2019

Contributor

Is it applicable to be clear whether this is IPv4 or IPv6? can it handle both? or would users of this module already know that?

@Qalthos

Qalthos approved these changes Jan 9, 2019

@rcarrillocruz rcarrillocruz merged commit 88eb01b into ansible:devel Jan 10, 2019

1 check passed

Shippable Run 101352 status is SUCCESS.
Details

Networking automation moved this from Needs Triage to Done Jan 10, 2019

kbreit added a commit to kbreit/ansible that referenced this pull request Jan 11, 2019

Checkpoint host (ansible#49936)
* Add checkpoint_host module

* Add state param to docstring

* Require ip_address if state is present

* Make else more explicit by doing and elif 404

* Remove bogus paren

* Add checkpoint_host module

knumskull added a commit to knumskull/ansible that referenced this pull request Jan 21, 2019

Checkpoint host (ansible#49936)
* Add checkpoint_host module

* Add state param to docstring

* Require ip_address if state is present

* Make else more explicit by doing and elif 404

* Remove bogus paren

* Add checkpoint_host module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment