New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint access rule #49937

Merged
merged 11 commits into from Jan 9, 2019

Conversation

Projects
None yet
4 participants
@rcarrillocruz
Copy link
Contributor

rcarrillocruz commented Dec 14, 2018

SUMMARY

Checkpoint access rule

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

checkpoint_access_rule

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 14, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:125:12: unnecessary-pass Unnecessary pass statement

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 723, in <module>
    main()
  File "../bin/plugin_formatter.py", line 681, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 296, in get_plugin_info
    if 'options' in doc and doc['options'] is None:
TypeError: argument of type 'NoneType' is not iterable
make: *** [modules] Error 1

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test pep8 [explain] failed with 9 errors:

lib/ansible/module_utils/network/checkpoint/checkpoint.py:29:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/checkpoint/checkpoint.py:32:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:19:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:38:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:59:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:65:15: E124 closing bracket does not match visual indentation
lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:71:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:85:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:130:1: E305 expected 2 blank lines after class or function definition, found 0

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 14, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 723, in <module>
    main()
  File "../bin/plugin_formatter.py", line 681, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 296, in get_plugin_info
    if 'options' in doc and doc['options'] is None:
TypeError: argument of type 'NoneType' is not iterable
make: *** [modules] Error 1

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/module_utils/network/checkpoint/checkpoint.py:29:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/checkpoint/checkpoint.py:32:1: E302 expected 2 blank lines, found 1

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 19, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 749, in <module>
    main()
  File "../bin/plugin_formatter.py", line 704, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 316, in get_plugin_info
    if 'options' in doc and doc['options'] is None:
TypeError: argument of type 'NoneType' is not iterable
make: *** [modules] Error 1

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/module_utils/network/checkpoint/checkpoint.py:29:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/checkpoint/checkpoint.py:32:1: E302 expected 2 blank lines, found 1

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 19, 2018

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:8:0: ImportError: No module named checkpoint.checkpoint

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:8:0: ImportError: No module named 'ansible.module_utils.network.checkpoint'

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:8:0: ImportError: No module named checkpoint.checkpoint

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:8:0: ModuleNotFoundError: No module named 'ansible.module_utils.network.checkpoint'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:8:0: ModuleNotFoundError: No module named 'ansible.module_utils.network.checkpoint'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:62:1: E302 expected 2 blank lines, found 1

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 19, 2018

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:8:0: ImportError: No module named checkpoint.checkpoint

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:8:0: ImportError: No module named checkpoint.checkpoint

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:8:0: ModuleNotFoundError: No module named 'ansible.module_utils.network.checkpoint'

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:8:0: ImportError: No module named 'ansible.module_utils.network.checkpoint'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:8:0: ModuleNotFoundError: No module named 'ansible.module_utils.network.checkpoint'

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 20, 2018

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:8:0: ImportError: No module named checkpoint.checkpoint

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:8:0: ImportError: No module named checkpoint.checkpoint

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:8:0: ImportError: No module named 'ansible.module_utils.network.checkpoint'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:8:0: ModuleNotFoundError: No module named 'ansible.module_utils.network.checkpoint'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:8:0: ModuleNotFoundError: No module named 'ansible.module_utils.network.checkpoint'

The test ansible-test sanity --test validate-modules [explain] failed with 8 errors:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: E105 GPLv3 license header not found in the first 20 lines of the module
lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: E305 DOCUMENTATION.options.enabled.type: not a valid value for dictionary value @ data['options']['enabled']['type']. Got 'boolean'
lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: E310 No EXAMPLES provided
lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: E312 No RETURN provided
lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'No module named 'ansible.module_utils.network.checkpoint''
lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:6:0: E106 Import found before documentation variables. All imports must appear below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:6:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/network/checkpoint:0:0: E502 Ansible module subdirectories must contain an __init__.py

click here for bot help

rcarrillocruz added some commits Jan 7, 2019

rcarrillocruz added some commits Jan 8, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 8, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

test/units/modules/network/checkpoint/test_checkpoint_access_rule.py:76:15: singleton-comparison Comparison to True should be just 'expr' or 'expr is True'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

test/units/modules/network/checkpoint/test_checkpoint_access_rule.py:76:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_access_rule.py:0:0: E324 Value for "default" from the argument_spec ('drop') for "action" does not match the documentation (None)

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Jan 8, 2019

@ansibot ansibot added core_review and removed needs_revision labels Jan 8, 2019

@rcarrillocruz rcarrillocruz merged commit 3e91ec2 into ansible:devel Jan 9, 2019

1 check passed

Shippable Run 101135 status is SUCCESS.
Details

rcarrillocruz added a commit to rcarrillocruz/ansible that referenced this pull request Jan 9, 2019

Checkpoint access rule (ansible#49937)
* WIP checkpoint_access_rule module

* Add fixes and docstrings

* Add dunder init

* Fix sanity tests issues

* Fix sanity test

* Add RETURN and EXAMPLES

* Fix example

* Fix pep8

* Add tests

* Fix pep8

* Fix pep8

kbreit added a commit to kbreit/ansible that referenced this pull request Jan 11, 2019

Checkpoint access rule (ansible#49937)
* WIP checkpoint_access_rule module

* Add fixes and docstrings

* Add dunder init

* Fix sanity tests issues

* Fix sanity test

* Add RETURN and EXAMPLES

* Fix example

* Fix pep8

* Add tests

* Fix pep8

* Fix pep8

knumskull added a commit to knumskull/ansible that referenced this pull request Jan 21, 2019

Checkpoint access rule (ansible#49937)
* WIP checkpoint_access_rule module

* Add fixes and docstrings

* Add dunder init

* Fix sanity tests issues

* Fix sanity test

* Add RETURN and EXAMPLES

* Fix example

* Fix pep8

* Add tests

* Fix pep8

* Fix pep8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment