New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add galaxy.html#dependencies link #49984

Merged
merged 3 commits into from Jan 3, 2019

Conversation

Projects
None yet
5 participants
@jdorel
Copy link
Contributor

jdorel commented Dec 16, 2018

+label: docsite_pr

SUMMARY

Add a link to the other way to include role dependencies.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

Doc

Add galaxy.html#dependencies link
+label: docsite_pr
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 16, 2018

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 16, 2018

The test ansible-test sanity --test docs-build [explain] failed with 1 error:

docs/docsite/rst/user_guide/playbooks_reuse_roles.rst:289:0: undefined-label: undefined label: https://docs.ansible.com/ansible/latest/reference_appendices/galaxy.html#dependencies (if the link has no caption the label must precede a section header)

click here for bot help

samccann added some commits Jan 3, 2019

@samccann
Copy link
Contributor

samccann left a comment

Thanks for the suggestion! the :ref: requires an anchor in the file you are linking to. I added the anchor and adjusted the text to match.

@samccann samccann merged commit d9ae906 into ansible:devel Jan 3, 2019

1 check passed

Shippable Run 100510 status is SUCCESS.
Details

@ansibot ansibot added core_review and removed needs_revision labels Jan 3, 2019

@samccann

This comment has been minimized.

Copy link
Contributor

samccann commented Jan 3, 2019

Thanks @jdorel for improving the Ansible documentation!

@jdorel

This comment has been minimized.

Copy link
Contributor

jdorel commented Jan 4, 2019

Thanks, I wasn't sure about the synthax I didn't know how to try different ones.

@jdorel jdorel deleted the jdorel:patch-1 branch Jan 4, 2019

rcarrillocruz added a commit to rcarrillocruz/ansible that referenced this pull request Jan 9, 2019

Add galaxy.html#dependencies link (ansible#49984)
* Add galaxy.html#dependencies link

+label: docsite_pr

kbreit added a commit to kbreit/ansible that referenced this pull request Jan 11, 2019

Add galaxy.html#dependencies link (ansible#49984)
* Add galaxy.html#dependencies link

+label: docsite_pr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment