New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to start support for Skydive integration with Ansible #50136

Closed
wants to merge 15 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@justjais
Copy link
Contributor

justjais commented Dec 19, 2018

SUMMARY

Skydive is a network analyzer tool, which helps in analyzing SDNs and network and with this PR Ansible API and lookup modules are added to query Skydive objects using skydive python client.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

skydive

ADDITIONAL INFORMATION

I'll be adding other skydive modules to fully integrate with Ansible shortly


justjais added some commits Dec 17, 2018

skydive module
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
skydive module
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
skydive module
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
skydive module
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
skydive module
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
skydive integration
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
skydive integration
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
skydive integration
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
skydive integration
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
skydive integration
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

@justjais justjais changed the title PR to start support Skydive modules integration with Ansible PR to start support for Skydive integration with Ansible Dec 19, 2018

@ansibot

This comment has been minimized.

skydive integration
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 19, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/module_utils/network/skydive/api.py:78:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/plugins/lookup/skydive_lookup.py:71:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/plugins/lookup/skydive_lookup.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/plugins/lookup/skydive_lookup.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/plugins/lookup/skydive_lookup.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/plugins/lookup/skydive_lookup.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/plugins/lookup/skydive_lookup.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with 10 errors:

docs/docsite/rst/plugins/connection.rst:39:0: undefined-label: undefined label: inventory_hostnames_lookup (if the link has no caption the label must precede a section header)
docs/docsite/rst/plugins/lookup.rst:49:0: undefined-label: undefined label: items_lookup (if the link has no caption the label must precede a section header)
docs/docsite/rst/plugins/lookup.rst:144:0: toc-tree-glob-pattern-no-match: toctree glob pattern 'lookup/*' didn't match any documents
docs/docsite/rst/reference_appendices/faq.rst:583:0: undefined-label: undefined label: vars_lookup (if the link has no caption the label must precede a section header)
docs/docsite/rst/scenario_guides/guide_infoblox.rst:46:0: undefined-label: undefined label: nios_lookup (if the link has no caption the label must precede a section header)
docs/docsite/rst/scenario_guides/guide_infoblox.rst:47:0: undefined-label: undefined label: nios_next_ip_lookup (if the link has no caption the label must precede a section header)
docs/docsite/rst/scenario_guides/guide_infoblox.rst:48:0: undefined-label: undefined label: nios_next_network_lookup (if the link has no caption the label must precede a section header)
docs/docsite/rst/scenario_guides/guide_infoblox.rst:56:0: undefined-label: undefined label: nios_lookup (if the link has no caption the label must precede a section header)
docs/docsite/rst/scenario_guides/guide_infoblox.rst:156:0: undefined-label: undefined label: nios_lookup (if the link has no caption the label must precede a section header)
docs/docsite/rst/scenario_guides/guide_infoblox.rst:208:0: undefined-label: undefined label: nios_next_ip_lookup (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test pep8 [explain] failed with 6 errors:

lib/ansible/module_utils/network/skydive/api.py:61:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/skydive/api.py:73:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/skydive/api.py:76:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/skydive/api.py:78:1: W391 blank line at end of file
lib/ansible/plugins/lookup/skydive_lookup.py:56:1: E302 expected 2 blank lines, found 1
lib/ansible/plugins/lookup/skydive_lookup.py:71:1: W391 blank line at end of file

The test ansible-test sanity --test shebang [explain] failed with 1 error:

lib/ansible/module_utils/network/skydive/api.py:0:0: file starts with a UTF-8 byte order mark

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Dec 19, 2018

@mattclay

This comment has been minimized.

Copy link
Member

mattclay commented Dec 19, 2018

@justjais These probably belong under net_tools instead of network.

@justjais

This comment has been minimized.

Copy link
Contributor

justjais commented Dec 20, 2018

@mattclay Thanks, I'll verify from @privateip and then update the project accordingly.

@ansibot ansibot added the stale_ci label Dec 28, 2018

justjais added some commits Jan 3, 2019

added new module support
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
added new module support
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
added new module support
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
cosmetic change
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 3, 2019

@justjais this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 3, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/plugins/lookup/skydive_lookup.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/plugins/lookup/skydive_lookup.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/plugins/lookup/skydive_lookup.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/plugins/lookup/skydive_lookup.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/plugins/lookup/skydive_lookup.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with 10 errors:

docs/docsite/rst/plugins/connection.rst:39:0: undefined-label: undefined label: inventory_hostnames_lookup (if the link has no caption the label must precede a section header)
docs/docsite/rst/plugins/lookup.rst:49:0: undefined-label: undefined label: items_lookup (if the link has no caption the label must precede a section header)
docs/docsite/rst/plugins/lookup.rst:144:0: toc-tree-glob-pattern-no-match: toctree glob pattern 'lookup/*' didn't match any documents
docs/docsite/rst/reference_appendices/faq.rst:606:0: undefined-label: undefined label: vars_lookup (if the link has no caption the label must precede a section header)
docs/docsite/rst/scenario_guides/guide_infoblox.rst:46:0: undefined-label: undefined label: nios_lookup (if the link has no caption the label must precede a section header)
docs/docsite/rst/scenario_guides/guide_infoblox.rst:47:0: undefined-label: undefined label: nios_next_ip_lookup (if the link has no caption the label must precede a section header)
docs/docsite/rst/scenario_guides/guide_infoblox.rst:48:0: undefined-label: undefined label: nios_next_network_lookup (if the link has no caption the label must precede a section header)
docs/docsite/rst/scenario_guides/guide_infoblox.rst:56:0: undefined-label: undefined label: nios_lookup (if the link has no caption the label must precede a section header)
docs/docsite/rst/scenario_guides/guide_infoblox.rst:156:0: undefined-label: undefined label: nios_lookup (if the link has no caption the label must precede a section header)
docs/docsite/rst/scenario_guides/guide_infoblox.rst:208:0: undefined-label: undefined label: nios_next_ip_lookup (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/skydive/skydive_capture.py:65:0: ImportError: cannot import name skydive_flow_topology

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/skydive/skydive_capture.py:65:0: ImportError: cannot import name skydive_flow_topology

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/skydive/skydive_capture.py:65:0: ImportError: cannot import name 'skydive_flow_topology'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/skydive/skydive_capture.py:65:0: ImportError: cannot import name 'skydive_flow_topology'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/skydive/skydive_capture.py:65:0: ImportError: cannot import name 'skydive_flow_topology' from 'ansible.module_utils.net_tools.nios.api' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/net_tools/nios/api.py)

The test ansible-test sanity --test shebang [explain] failed with 1 error:

lib/ansible/module_utils/network/skydive/api.py:0:0: file starts with a UTF-8 byte order mark

click here for bot help

@justjais

This comment has been minimized.

Copy link
Contributor

justjais commented Jan 4, 2019

Closing this PR and will be opening a new PR with the change.

@justjais justjais closed this Jan 4, 2019

@justjais justjais deleted the justjais:skydive_modules branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment