New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - [timezone module] fixed regex to support RHEL6 #50289

Open
wants to merge 7 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@tmshn
Copy link
Contributor

tmshn commented Dec 24, 2018

TODOs:

  • adjtime
  • fix config parser
SUMMARY

Fixed regex in NosystemdTimezone so that it handles quotation marks better.

This fixes the first problem of #42197 (error on RHEL6).

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

timezone module

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 24, 2018

@tmshn tmshn force-pushed the tmshn:timezone-regexp branch from 0b47c30 to 696989e Dec 24, 2018

@tmshn tmshn changed the title [wip] [timezone module] fixed regexp to support RHEL6 [wip] [timezone module] fixed regex to support RHEL6 Dec 24, 2018

tmshn added some commits Dec 24, 2018

@ansibot ansibot added the stale_ci label Jan 1, 2019

@ansibot ansibot removed the stale_ci label Jan 6, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 6, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/system/timezone.py:387:48: bad-whitespace Exactly one space required around assignment                 self.conf['hwclock']['filename']=filename                                                 ^

The test ansible-test sanity --test pep8 [explain] failed with 6 errors:

lib/ansible/modules/system/timezone.py:381:161: E501 line too long (162 > 160 characters)
lib/ansible/modules/system/timezone.py:387:49: E225 missing whitespace around operator
lib/ansible/modules/system/timezone.py:462:29: E261 at least two spaces before inline comment
lib/ansible/modules/system/timezone.py:498:29: E128 continuation line under-indented for visual indent
lib/ansible/modules/system/timezone.py:499:29: E128 continuation line under-indented for visual indent
lib/ansible/modules/system/timezone.py:500:29: E128 continuation line under-indented for visual indent

click here for bot help

@mattclay mattclay changed the title [wip] [timezone module] fixed regex to support RHEL6 WIP - [timezone module] fixed regex to support RHEL6 Jan 7, 2019

@mattclay mattclay added the WIP label Jan 7, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 7, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/system/timezone.py:387:48: bad-whitespace Exactly one space required around assignment                 self.conf['hwclock']['filename']=filename                                                 ^

The test ansible-test sanity --test pep8 [explain] failed with 6 errors:

lib/ansible/modules/system/timezone.py:381:161: E501 line too long (162 > 160 characters)
lib/ansible/modules/system/timezone.py:387:49: E225 missing whitespace around operator
lib/ansible/modules/system/timezone.py:462:29: E261 at least two spaces before inline comment
lib/ansible/modules/system/timezone.py:498:29: E128 continuation line under-indented for visual indent
lib/ansible/modules/system/timezone.py:499:29: E128 continuation line under-indented for visual indent
lib/ansible/modules/system/timezone.py:500:29: E128 continuation line under-indented for visual indent

click here for bot help

@ansibot ansibot removed the needs_triage label Jan 7, 2019

@ansibot ansibot added the stale_ci label Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment