New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added timestamps to ios_command module #50323

Open
wants to merge 1 commit into
base: devel
from

Conversation

@vaneuk
Copy link
Contributor

vaneuk commented Dec 26, 2018

ios_command module now returns timestamps field, which shows command execution time

SUMMARY

Added information about time when command was issued on remote device.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

before

ok: [ios1] => {
    "output": {
        "changed": false, 
        "failed": false, 
        "stdout": [
            "*16:32:49.138 MSK Wed Dec 26 2018", 
            "Neighbor ID     Pri   State           Dead Time   Address         Interface\n172.31.255.202    1   FULL/DR         00:00:39    10.10.10.20     TenGigabitEthernet1/3"
        ], 
        "stdout_lines": [
            [
                "*16:32:49.138 MSK Wed Dec 26 2018"
            ], 
            [
                "Neighbor ID     Pri   State           Dead Time   Address         Interface", 
                "172.31.255.202    1   FULL/DR         00:00:39    10.10.10.20     TenGigabitEthernet1/3"
            ]
        ]
    }
}

after

ok: [ios1] => {
    "output": {
        "changed": false, 
        "failed": false, 
        "stdout": [
            "*16:37:10.386 MSK Wed Dec 26 2018", 
            "Neighbor ID     Pri   State           Dead Time   Address         Interface\n172.31.255.202    1   FULL/DR         00:00:35    10.10.10.20     TenGigabitEthernet1/3"
        ], 
        "stdout_lines": [
            [
                "*16:37:10.386 MSK Wed Dec 26 2018"
            ], 
            [
                "Neighbor ID     Pri   State           Dead Time   Address         Interface", 
                "172.31.255.202    1   FULL/DR         00:00:35    10.10.10.20     TenGigabitEthernet1/3"
            ]
        ], 
        "timestamps": [
            "2018-12-26T16:37:10", 
            "2018-12-26T16:37:10"
        ]
    }
}
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 26, 2018

@vaneuk, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@abenokraitis abenokraitis added this to Needs Triage in Networking via automation Jan 15, 2019

@abenokraitis abenokraitis added this to the 2.8.0 milestone Jan 15, 2019

@@ -2883,3 +2883,7 @@ def human_to_bytes(self, number, isbits=False):

def get_module_path():
return os.path.dirname(os.path.realpath(__file__))


def get_timestamp():

This comment has been minimized.

@trishnaguha

trishnaguha Jan 17, 2019

Member

since get_timestamp was added in the PR https://github.com/ansible/ansible/pull/50261/files#diff-90085fdcec6ed8b273ba885eaee60328R2888, please remove it from this PR.

This comment has been minimized.

@vaneuk

vaneuk Jan 18, 2019

Contributor

rebased this branch, so get_timestamp is no longer present in this PR

added timestamps to ios_command module
ios_command module now returns timestamps field, which shows command execution time

@vaneuk vaneuk force-pushed the vaneuk:ios_timestamps branch from a06bc41 to 516c416 Jan 18, 2019

@ansibot ansibot removed the stale_ci label Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment