New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kali Linux detection. #50331

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
5 participants
@jbenden
Copy link
Contributor

jbenden commented Dec 26, 2018

SUMMARY

This patch adds support for the auto-detection of Kali Linux.

Upon applying this patch, Kali shows as the ansible_distribution variable, instead of defaulting (incorrectly) to ClearLinux.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

facts module, distribution file.

ADDITIONAL INFORMATION
(master)⚡ % ansible nanopi -i environments/prod -m setup | grep distribution                                                                            
        "ansible_distribution": "ClearLinux", 
        "ansible_distribution_file_parsed": true, 
        "ansible_distribution_file_path": "/usr/lib/os-release", 
        "ansible_distribution_file_variety": "ClearLinux", 
        "ansible_distribution_major_version": "\"2019.1\"", 
        "ansible_distribution_release": "kali", 
        "ansible_distribution_version": "\"2019.1\"", 
(master)⚡ % ansible nanopi -i environments/prod -m setup | grep distribution                                                                    
        "ansible_distribution": "Kali", 
        "ansible_distribution_file_parsed": true, 
        "ansible_distribution_file_path": "/etc/os-release", 
        "ansible_distribution_file_variety": "Debian", 
        "ansible_distribution_major_version": "kali-rolling", 
        "ansible_distribution_release": "kali-rolling", 
        "ansible_distribution_version": "kali-rolling", 
@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Dec 27, 2018

@jbenden Thanks for the PR. Could you please add a test case for this change here ? Thanks.

@jbenden jbenden force-pushed the jbenden:kali-distribution branch from 0791d2f to bb20350 Dec 27, 2018

@ansibot ansibot removed the small_patch label Dec 27, 2018

Add support for Kali Linux detection.
Signed-off-by: Joseph Benden <joe@benden.us>

@jbenden jbenden force-pushed the jbenden:kali-distribution branch from bb20350 to 4af5ca6 Dec 27, 2018

@jbenden

This comment has been minimized.

Copy link
Contributor

jbenden commented Dec 27, 2018

@Akasurde I've made changes that are hopefully acceptable. After your request came in, I realized that the full output wasn't completely acceptable under Kali, so I made a small change to require the lsb-release file; so that I could parse out the release better.

@Akasurde Akasurde requested review from bcoca and Akasurde Dec 28, 2018

@bcoca

bcoca approved these changes Jan 2, 2019

@Akasurde Akasurde merged commit d810acf into ansible:devel Jan 3, 2019

1 check passed

Shippable Run 100368 status is SUCCESS.
Details

@sivel sivel removed needs_triage labels Jan 3, 2019

rcarrillocruz added a commit to rcarrillocruz/ansible that referenced this pull request Jan 9, 2019

Add support for Kali Linux detection. (ansible#50331)
Signed-off-by: Joseph Benden <joe@benden.us>

kbreit added a commit to kbreit/ansible that referenced this pull request Jan 11, 2019

Add support for Kali Linux detection. (ansible#50331)
Signed-off-by: Joseph Benden <joe@benden.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment