New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AIX support to reboot module #50353

Merged
merged 2 commits into from Jan 8, 2019

Conversation

Projects
None yet
4 participants
@gforster
Copy link
Contributor

gforster commented Dec 27, 2018

SUMMARY

Currently no AIX support for the reboot module as mentioned in #49712. Added correct params.

Fixes #49712

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

reboot

ADDITIONAL INFORMATION

@gforster

This comment has been minimized.

Copy link
Contributor

gforster commented Dec 28, 2018

I'm not sure I understand why a missing python module in the Fedora 29 test target is causing this PR to fail. I'm happy to try and revise my work, but I don't see any room for a change that would affect this.

@ansibot

This comment was marked as resolved.

Copy link
Contributor

ansibot commented Jan 4, 2019

@gforster this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@dagwieers
Copy link
Member

dagwieers left a comment

LGTM

@dagwieers

This comment has been minimized.

Copy link
Member

dagwieers commented Jan 5, 2019

@samdoran We probably want to backport this to Ansible v2.7.

@dagwieers dagwieers requested a review from samdoran Jan 8, 2019

@dagwieers dagwieers removed the needs_triage label Jan 8, 2019

@samdoran

This comment has been minimized.

Copy link
Member

samdoran commented Jan 8, 2019

@gforster Please create a changelog fragment. See this fragment as an example.

@dagwieers Yes, this will be backported as a bug fix, similar to #50616.

@ansibot ansibot added the bug label Jan 8, 2019

@gforster gforster force-pushed the gforster:devel branch from d7b7b7a to db3c3b4 Jan 8, 2019

@dagwieers dagwieers added aix and removed aix labels Jan 8, 2019

@dagwieers

This comment has been minimized.

Copy link
Member

dagwieers commented Jan 8, 2019

rebuild_merge

@ansibot ansibot added shipit and removed needs_revision labels Jan 8, 2019

@ansibot ansibot merged commit 1dac10e into ansible:devel Jan 8, 2019

1 check passed

Shippable Run 101184 status is SUCCESS.
Details

rcarrillocruz added a commit to rcarrillocruz/ansible that referenced this pull request Jan 9, 2019

Add AIX support to reboot module (ansible#50353)
* Add ability for reboot module to work for AIX

* changelog for AIX reboot support

samdoran added a commit to samdoran/ansible that referenced this pull request Jan 9, 2019

[stable-2.7] Add AIX support to reboot module (ansible#50353)
* Add ability for reboot module to work for AIX

* changelog for AIX reboot support.
(cherry picked from commit 1dac10e)

Co-authored-by: trogdor_the_burninator <gforster@users.noreply.github.com>

samdoran added a commit to samdoran/ansible that referenced this pull request Jan 9, 2019

[stable-2.7] Add AIX support to reboot module (ansible#50353)
* Add ability for reboot module to work for AIX

* changelog for AIX reboot support.
(cherry picked from commit 1dac10e)

Co-authored-by: trogdor_the_burninator <gforster@users.noreply.github.com>
Signed-off-by: Sam Doran <sdoran@redhat.com>

samdoran added a commit to samdoran/ansible that referenced this pull request Jan 10, 2019

[stable-2.7] Add AIX support to reboot module (ansible#50353)
* Add ability for reboot module to work for AIX

* changelog for AIX reboot support.
(cherry picked from commit 1dac10e)

Co-authored-by: trogdor_the_burninator <gforster@users.noreply.github.com>
Signed-off-by: Sam Doran <sdoran@redhat.com>

abadger added a commit that referenced this pull request Jan 10, 2019

[stable-2.7] Add AIX support to reboot module (#50353)
* Add ability for reboot module to work for AIX

* changelog for AIX reboot support.
(cherry picked from commit 1dac10e)

Co-authored-by: trogdor_the_burninator <gforster@users.noreply.github.com>
Signed-off-by: Sam Doran <sdoran@redhat.com>

kbreit added a commit to kbreit/ansible that referenced this pull request Jan 11, 2019

Add AIX support to reboot module (ansible#50353)
* Add ability for reboot module to work for AIX

* changelog for AIX reboot support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment