Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(action/script) Fix windows absolute path detection #50365

Merged
merged 1 commit into from Jan 6, 2019
Merged

(action/script) Fix windows absolute path detection #50365

merged 1 commit into from Jan 6, 2019

Conversation

spoyd
Copy link
Contributor

@spoyd spoyd commented Dec 28, 2018

SUMMARY

Script action plugin uses invalid regex method to detect windows absolute paths.
Should use 'match()' instead of 'matches()'.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugin/action/script.py

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 28, 2018
@spoyd spoyd mentioned this pull request Dec 29, 2018
Closed
dagwieers
dagwieers approved these changes Jan 5, 2019
View reviewed changes
Copy link
Member

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dagwieers dagwieers added windows Windows community and removed needs_triage Needs a first human triage before being processed. labels Jan 5, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 5, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 6, 2019
@jborean93 jborean93 mentioned this pull request Jan 6, 2019
Open
@jborean93
Copy link
Contributor

So this fixes this issue but it looks like chdir on Windows still fails for other reasons and hasn't for a few older releases as well. I've created #50585 to help track down these issues but thanks for fixing the first issue.

@jborean93 jborean93 merged commit 9693a55 into ansible:devel Jan 6, 2019
@spoyd spoyd deleted the script-patch-1 branch January 7, 2019 04:17
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@spoyd @kbreit
(action/script) Fix windows absolute path detection when executing po…
aad1a87 
…wershell script (ansible#50365)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

@jborean93 jborean93 jborean93 approved these changes

Assignees

@jborean93 jborean93

Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. new_contributor This PR is the first contribution by a new community member. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spoyd @jborean93 @dagwieers @ansibot