New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(action/script) Fix windows absolute path detection #50365

Merged
merged 1 commit into from Jan 6, 2019

Conversation

Projects
None yet
4 participants
@spoyd
Copy link
Contributor

spoyd commented Dec 28, 2018

SUMMARY

Script action plugin uses invalid regex method to detect windows absolute paths.
Should use 'match()' instead of 'matches()'.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugin/action/script.py

ADDITIONAL INFORMATION

@dagwieers
Copy link
Member

dagwieers left a comment

LGTM

@dagwieers dagwieers added windows and removed needs_triage labels Jan 5, 2019

@dagwieers dagwieers requested a review from jborean93 Jan 5, 2019

@ansibot ansibot added core_review and removed needs_revision labels Jan 5, 2019

@jborean93

This comment has been minimized.

Copy link
Contributor

jborean93 commented Jan 6, 2019

So this fixes this issue but it looks like chdir on Windows still fails for other reasons and hasn't for a few older releases as well. I've created #50585 to help track down these issues but thanks for fixing the first issue.

@jborean93 jborean93 merged commit 9693a55 into ansible:devel Jan 6, 2019

1 check passed

Shippable Run 100756 status is SUCCESS.
Details

@spoyd spoyd deleted the spoyd:script-patch-1 branch Jan 7, 2019

rcarrillocruz added a commit to rcarrillocruz/ansible that referenced this pull request Jan 9, 2019

kbreit added a commit to kbreit/ansible that referenced this pull request Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment