Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
If product_name is set to OEM message read board name instead #50396
Some desktop motherboards(like gigabyte) may not have product field set. Instead we can use "Product Name" from the "Base Board Information" section of dmi to provide meaningful value.
very specific string to check for "To be filled by O.E.M." don't know if there are any other values that might come up for unset product_name field.
Not sure if there is any try/except required here since presence of dmi keys confirmed above and get_file_conent handles any empty/missing files.
@mstarikov: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.
Here are the items we could not find in your description:
Please set the description of this pullrequest with this template:
Thank you very much for this submission. We do not believe that this should be special cases like this. Instead we recommend one of the following:
Thanks for looking into that.
Could I ask you to expand on what is the motivation behind that decision?
The "if statement" triggered on very particular string so wouldn't affect any other functionality and I'm sure this change wouldn't add much(if at all) to the execution time.
I understand that currently ansible is used primarily on servers and VMs, but if it to become a default standard configuration tool(I certainly hope so) and reach desktops that would affect pretty much every off-the-shelf motherboard.
Thanks for the reply @bcoca. Yes, of course that makes sense. I'm not sure what I was thinking with the first commit - silently replacing data source is the kind of dodgy practice that would always get you in trouble. Anywho, Just pushed commit by adding board_name in both /sys and dmidecode. Please advise.