New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres tablespace #50406

Open
wants to merge 8 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@antoinell
Copy link

antoinell commented Dec 30, 2018

SUMMARY

Add support to select a tablespace when creating or updating a postgres database with the postgresql_db module.
Fixes #5954

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

postgresql_db

ADDITIONAL INFORMATION

similar to #37953
a parallel pull request #50568 has been submitted to add a module allowing to create a tablespace.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 30, 2018

@antoinell this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@antoinell antoinell force-pushed the antoinell:postgres-tablespace branch from ced147c to 9358f8d Dec 30, 2018

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 30, 2018

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 30, 2018

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/database/postgresql/postgresql_tablespace.py:127:13: trailing-whitespace Trailing whitespace
lib/ansible/modules/database/postgresql/postgresql_tablespace.py:173:42: bad-whitespace No space allowed around keyword argument assignment         location=dict(required=True, type = "path"),                                           ^

The test ansible-test sanity --test pep8 [explain] failed with 6 errors:

lib/ansible/modules/database/postgresql/postgresql_db.py:46:27: W291 trailing whitespace
lib/ansible/modules/database/postgresql/postgresql_tablespace.py:127:14: W291 trailing whitespace
lib/ansible/modules/database/postgresql/postgresql_tablespace.py:133:1: E303 too many blank lines (4)
lib/ansible/modules/database/postgresql/postgresql_tablespace.py:173:42: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/database/postgresql/postgresql_tablespace.py:173:44: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/database/postgresql/postgresql_tablespace.py:211:5: E303 too many blank lines (2)

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/database/postgresql/postgresql_db.py:0:0: E309 version_added for new option (tablespace) should be 2.8. Currently 0.0
lib/ansible/modules/database/postgresql/postgresql_tablespace.py:0:0: E305 DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got 'Thesys_cat'
lib/ansible/modules/database/postgresql/postgresql_tablespace.py:0:0: E307 version_added should be 2.8. Currently 0.6
lib/ansible/modules/database/postgresql/postgresql_tablespace.py:0:0: E312 No RETURN provided
lib/ansible/modules/database/postgresql/postgresql_tablespace.py:0:0: E322 "name" is listed in the argument_spec, but not documented in the module

click here for bot help

Antoine Levy-Lambert
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 3, 2019

@Andersson007 @Dorn- @andytom @b6d @dschep @jensdepuydt @matburt @nerzhul

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@nerzhul

This comment has been minimized.

Copy link
Contributor

nerzhul commented Jan 4, 2019

hello @antoinell , thanks for your commit. You should do two PR, one to modify the postgresql_db module, one to add postgresql_tablespace module.
For postgresql_db change it's fine to me

@Dorn-

This comment has been minimized.

Copy link
Contributor

Dorn- commented Jan 4, 2019

Yup, as @nerzhul said, it should be two distinct PR.
One to add the postgresql tablespace module and another to add a parameter to the db module.
I tried to add this tablespace module here: #23603 (I'll look to update it asap)

@ansibot ansibot removed the new_module label Jan 4, 2019

@antoinell

This comment has been minimized.

Copy link

antoinell commented Jan 4, 2019

Shippable tests fail on rhel 7.6.1 with this

"echo \"create tablespace ansible_tablespace location '/tmp/ansible_tablespace';\" | psql -d postgres",
"ERROR:  could not set permissions on directory \"/tmp/ansible_tablespace\": Permission denied"``

Antoine Levy-Lambert and others added some commits Jan 4, 2019

@antoinell

This comment has been minimized.

Copy link

antoinell commented Jan 8, 2019

@dorn @nerzhul I have split the pull requests between change to the postgresql_db module and creation of a new postgresql_tablespace module in #50568 .

@ansibot ansibot added the stale_ci label Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment