New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lookup module: manifold #50435

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@galanoff
Copy link

galanoff commented Jan 2, 2019

SUMMARY

Add Manifold.co integration. The plugin fetches resource credentials from Manifold service.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Kyrylo Galanov
New lookup module: manifold
Add Manifold.co integration. The plugin fetches resource credentials
from Manifold service.
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 2, 2019

The test ansible-test sanity --test pylint [explain] failed with 8 errors:

test/units/plugins/lookup/test_manifold.py:197:63: unnecessary-lambda Lambda may not be necessary
test/units/plugins/lookup/test_manifold.py:388:86: ansible-format-automatic-specification Format string contains automatic field numbering specification
test/units/plugins/lookup/test_manifold.py:400:86: ansible-format-automatic-specification Format string contains automatic field numbering specification
test/units/plugins/lookup/test_manifold.py:413:86: ansible-format-automatic-specification Format string contains automatic field numbering specification
test/units/plugins/lookup/test_manifold.py:427:86: ansible-format-automatic-specification Format string contains automatic field numbering specification
test/units/plugins/lookup/test_manifold.py:445:86: ansible-format-automatic-specification Format string contains automatic field numbering specification
test/units/plugins/lookup/test_manifold.py:458:86: ansible-format-automatic-specification Format string contains automatic field numbering specification
test/units/plugins/lookup/test_manifold.py:472:86: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test pylint [explain] failed with 6 errors:

lib/ansible/plugins/lookup/manifold.py:104:29: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/plugins/lookup/manifold.py:116:25: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/plugins/lookup/manifold.py:234:39: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/plugins/lookup/manifold.py:242:39: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/plugins/lookup/manifold.py:257:35: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/plugins/lookup/manifold.py:277:31: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test no-main-display [explain] failed with 1 error:

lib/ansible/plugins/lookup/manifold.py:73:5: Display is a singleton, just import and instantiate

The test ansible-test sanity --test replace-urlopen [explain] failed with 1 error:

test/units/plugins/lookup/test_manifold.py:270:29: use `ansible.module_utils.urls.open_url` instead of `urlopen`

The test ansible-test sanity --test pep8 [explain] failed with 9 errors:

test/units/plugins/lookup/test_manifold.py:388:128: E502 the backslash is redundant between brackets
test/units/plugins/lookup/test_manifold.py:389:82: E128 continuation line under-indented for visual indent
test/units/plugins/lookup/test_manifold.py:400:129: E502 the backslash is redundant between brackets
test/units/plugins/lookup/test_manifold.py:413:129: E502 the backslash is redundant between brackets
test/units/plugins/lookup/test_manifold.py:427:129: E502 the backslash is redundant between brackets
test/units/plugins/lookup/test_manifold.py:445:129: E502 the backslash is redundant between brackets
test/units/plugins/lookup/test_manifold.py:458:129: E502 the backslash is redundant between brackets
test/units/plugins/lookup/test_manifold.py:472:129: E502 the backslash is redundant between brackets
test/units/plugins/lookup/test_manifold.py:536:30: E127 continuation line over-indented for visual indent

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/plugins/lookup/manifold.py:58:15: error RETURN: syntax error: could not find expected ':'

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Jan 2, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 3, 2019

The test ansible-test sanity --test replace-urlopen [explain] failed with 1 error:

test/units/plugins/lookup/test_manifold.py:270:29: use `ansible.module_utils.urls.open_url` instead of `urlopen`

click here for bot help

Kyrylo Galanov added some commits Jan 3, 2019

@samdoran samdoran removed the needs_triage label Jan 8, 2019

@ansibot ansibot added core_review and removed needs_revision labels Jan 8, 2019

@ansibot ansibot added the stale_ci label Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment