New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding module azure_rm_virtualmachinescalesetinstance_facts #50440

Merged
merged 10 commits into from Jan 7, 2019

Conversation

Projects
None yet
3 participants
@zikalino
Copy link
Contributor

zikalino commented Jan 2, 2019

SUMMARY

This module provides functionality to get facts about VM instances in VMSS.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_virtualmachinescalesetinstance_facts

ADDITIONAL INFORMATION

@zikalino zikalino requested a review from yungezz Jan 2, 2019

@zikalino

This comment has been minimized.

Copy link
Contributor

zikalino commented Jan 2, 2019

will add test in a moment

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 4, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 4, 2019

The test ansible-test sanity --test docs-build [explain] failed with 2 errors:

docs/docsite/rst/modules/list_of_all_modules.rst:304:0: undefined-label: undefined label: azure_rm_virtualmachinescalesetvm_facts_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_cloud_modules.rst:309:0: undefined-label: undefined label: azure_rm_virtualmachinescalesetvm_facts_module (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/azure/azure_rm_virtualmachinescalesetvm_facts.py:66:161: E501 line too long (179 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_virtualmachinescalesetvm_facts.py:190:5: E303 too many blank lines (2)

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_virtualmachinescalesetvm_facts.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got 'azure_rm_computevirtualmachinescalesetvm_facts'

click here for bot help

zikalino added some commits Jan 4, 2019


DOCUMENTATION = '''
---
module: azure_rm_virtualmachinescalesetvm_facts

This comment has been minimized.

@yungezz

yungezz Jan 4, 2019

Contributor

how about virtualmachinescalsetinstance_facts module? to align term with both rest and sdk

This comment has been minimized.

@zikalino

zikalino Jan 4, 2019

Contributor

yes, I was thinking about exactly that change.. I will change it

returned: always
type: str
sample: myVMSS_2
latest_model_applied:

This comment has been minimized.

@yungezz

yungezz Jan 4, 2019

Contributor

the returned info is too limited, what about vnet/subnet, disk, sku, status(power_state), which showed at portal?

This comment has been minimized.

@zikalino

zikalino Jan 4, 2019

Contributor

there can be quite a lot of info here... that's why i wanted to limit returned values in the first release.

This comment has been minimized.

@zikalino

zikalino Jan 4, 2019

Contributor

but i think i can add some more ;-)

@ansibot ansibot removed the needs_triage label Jan 4, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 4, 2019

The test ansible-test sanity --test docs-build [explain] failed with 2 errors:

docs/docsite/rst/modules/list_of_all_modules.rst:304:0: undefined-label: undefined label: azure_rm_virtualmachinescalesetinstance_facts_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_cloud_modules.rst:309:0: undefined-label: undefined label: azure_rm_virtualmachinescalesetinstance_facts_module (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_virtualmachinescalesetinstance_facts.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got 'azure_rm_virtualmachinescalesetvm_facts'

click here for bot help

zikalino added some commits Jan 4, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 5, 2019

@Madhura-CSI @brusMX @caohai @devigned @gustavomcarmo @haroldwongms @iphilpot @julienstroheker @lmazuel @obsoleted @sozercan @trstringer @tstringer @xscript @yaweiw @yuwzho

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@zikalino zikalino changed the title adding module azure_rm_virtualmachinescalesetvm_facts adding module azure_rm_virtualmachinescalesetinstance_facts Jan 5, 2019

@yungezz
Copy link
Contributor

yungezz left a comment

LGTM. need more returned properties.


RETURN = '''
instances:
description: A list of dictionaries containing facts for Virtual Machine Scale Set V M.

This comment has been minimized.

@yungezz

yungezz Jan 7, 2019

Contributor

extra whitespace between V and M.

This comment has been minimized.

@zikalino

zikalino Jan 7, 2019

Contributor

fixed

type: str
sample: Succeeded
vm_id:
description:

This comment has been minimized.

@yungezz

yungezz Jan 7, 2019

Contributor

could you pls add status(powerstate) in facts?

This comment has been minimized.

@zikalino

zikalino Jan 7, 2019

Contributor

added

zikalino added some commits Jan 7, 2019

@yungezz

yungezz approved these changes Jan 7, 2019

@zikalino

This comment has been minimized.

Copy link
Contributor

zikalino commented Jan 7, 2019

shipit

1 similar comment
@yungezz

This comment has been minimized.

Copy link
Contributor

yungezz commented Jan 7, 2019

shipit

@ansibot ansibot added shipit and removed community_review labels Jan 7, 2019

@zikalino zikalino merged commit 98b0ef3 into ansible:devel Jan 7, 2019

1 check passed

Shippable Run 100842 status is SUCCESS.
Details

@zikalino zikalino deleted the VSChina:adding-scaleset-instances-facts branch Jan 7, 2019

rcarrillocruz added a commit to rcarrillocruz/ansible that referenced this pull request Jan 9, 2019

kbreit added a commit to kbreit/ansible that referenced this pull request Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment