New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for mysql_db notes #50444

Merged
merged 3 commits into from Jan 4, 2019

Conversation

Projects
None yet
4 participants
@richlv
Copy link
Contributor

richlv commented Jan 2, 2019

SUMMARY
  • Remove duplicate module requirement from mysql_db that's already found in the mysql document fragment.
  • Simplify module installation section and mention RHEL.
  • Fix a typo in "than".

Fixes #49620

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

mysql

richlv added some commits Jan 2, 2019

Update mysql_db.py
Simplify the requirement section to avoid duplicating info already in mysql_document_fragment.
Update mysql.py
Package installation section simplified, mentioned RHEL; a typo fix in "than".
is as easy as yum install python2-PyMySQL. (See M(yum).)
- Requires the PyMySQL (Python 2.7 and Python 3.X) or MySQL-python (Python 2.X) package on the remote host.
The Python package may be installed with apt-get install python-pymysql (Ubuntu; see M(apt)) or
yum install python2-PyMySQL (RHEL/CentOS/Fedora; see M(yum)).

This comment has been minimized.

@Akasurde

Akasurde Jan 2, 2019

Member

Newer Fedora versions uses dnf by-default. It may be worth adding that as well if you are editing in these lines. What say ?

This comment has been minimized.

@Akasurde

Akasurde Jan 2, 2019

Member

Rest LGTM

This comment has been minimized.

@richlv

richlv Jan 3, 2019

Contributor

Sorry, I don't feel familiar enough with Fedora/dnf (just read that it's "the future yum"), it would be safer for somebody else to clarify that.

@Akasurde Akasurde requested review from acozine and samccann Jan 2, 2019

@Akasurde Akasurde removed the needs_triage label Jan 2, 2019

@samccann
Copy link
Contributor

samccann left a comment

added dnf per review comments.

@Akasurde
Copy link
Member

Akasurde left a comment

LGTM

@samccann

This comment has been minimized.

Copy link
Contributor

samccann commented Jan 3, 2019

Hmm. I'm not sure why shippable is failing. Any ideas @Akasurde ?

@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Jan 3, 2019

@samccann it is happening due to upstream packaging bug in Fedora 29. It is being tracked here - #50386 #50387 #50394. We will need to wait for PR #50430 if we want clean CI run.

@Akasurde Akasurde merged commit 73ffe68 into ansible:devel Jan 4, 2019

1 check passed

Shippable Run 100597 status is SUCCESS.
Details

rcarrillocruz added a commit to rcarrillocruz/ansible that referenced this pull request Jan 9, 2019

Update documentation for mysql_db notes (ansible#50444)
* Simplify the requirement section to avoid duplicating info already in mysql_document_fragment.
* Package installation section simplified, mentioned RHEL; a typo fix in "than".
* added dnf for Fedora

kbreit added a commit to kbreit/ansible that referenced this pull request Jan 11, 2019

Update documentation for mysql_db notes (ansible#50444)
* Simplify the requirement section to avoid duplicating info already in mysql_document_fragment.
* Package installation section simplified, mentioned RHEL; a typo fix in "than".
* added dnf for Fedora
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment