New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gather_facts network platforms #50591

Open
wants to merge 13 commits into
base: devel
from

Conversation

@trishnaguha
Copy link
Member

trishnaguha commented Jan 7, 2019

SUMMARY

gather_facts network platforms
This PR will only get in if the PR #49399 does not get in 2.8

Platforms:
EOS
IOS
IOSXR
NXOS
VYOS
JUNOS

ISSUE TYPE
  • Feature Pull Request

@trishnaguha trishnaguha requested a review from privateip Jan 7, 2019

@trishnaguha trishnaguha force-pushed the trishnaguha:network_cli_facts branch from 6899c8d to 795c60d Jan 7, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jan 7, 2019

@trishnaguha trishnaguha added networking and removed needs_triage labels Jan 7, 2019

@trishnaguha trishnaguha force-pushed the trishnaguha:network_cli_facts branch 2 times, most recently from bf7b3c0 to 564af6f Jan 9, 2019

@trishnaguha trishnaguha added this to Needs Triage in Networking via automation Jan 15, 2019

@trishnaguha trishnaguha changed the title [WIP] gather_facts network platforms gather_facts network platforms Jan 15, 2019

@trishnaguha trishnaguha removed the WIP label Jan 15, 2019

@trishnaguha trishnaguha moved this from Needs Triage to Review in Networking Jan 15, 2019

@trishnaguha trishnaguha force-pushed the trishnaguha:network_cli_facts branch from 22e3837 to a646c6a Jan 15, 2019

@ansible ansible deleted a comment from ansibot Jan 15, 2019

@ansible ansible deleted a comment from ansibot Jan 15, 2019

@ansible ansible deleted a comment from ansibot Jan 15, 2019

@ansible ansible deleted a comment from ansibot Jan 15, 2019

@ansible ansible deleted a comment from ansibot Jan 15, 2019

@abenokraitis

This comment has been minimized.

Copy link
Contributor

abenokraitis commented Jan 15, 2019

@abenokraitis abenokraitis added this to the 2.8.0 milestone Jan 15, 2019

@mattclay

This comment has been minimized.

Copy link
Member

mattclay commented Jan 15, 2019

@trishnaguha

This comment has been minimized.

Copy link
Member Author

trishnaguha commented Feb 1, 2019

privateip and others added some commits Oct 30, 2018

WIP: network facts implementation
(cherry picked from commit bb69e5e)

return facts only when connection plugin is network_cli

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
ios gather facts
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
Add nxos
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
add iosxr
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
iosxr
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
vyos network facts
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
pep8 fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
fix pylint issues
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
update network_platform factcollector
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
update import in network_collectors
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
junos gather_facts
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
fix review comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
fix sanity and pep8 failures
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

@trishnaguha trishnaguha force-pushed the trishnaguha:network_cli_facts branch from 9e2881d to 01743b6 Feb 1, 2019

@ansibot ansibot added core_review and removed needs_revision labels Feb 3, 2019

@ansibot ansibot added the stale_ci label Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment