New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module zabbix_maintenance to create maintenance windows in zabbix #5062

Closed
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
7 participants
@abulimov
Contributor

abulimov commented Nov 26, 2013

Hello. I've wrote simple module to create and remove maintenance windows in Zabbix. It uses zabbix-api python module.

With this module you can, for example, set your hosts to maintenance mode before rolling update, and delete maintenance window after update.

@gregbuehler

This comment has been minimized.

Show comment
Hide comment
@gregbuehler

gregbuehler commented Nov 26, 2013

+1

@mpdehaan

This comment has been minimized.

Show comment
Hide comment
@mpdehaan

mpdehaan Nov 26, 2013

Contributor

Just thinking aloud, do we want to just call this one "zabbix" and try to make the API signature somewhat resemble the nagios module, or no?

(Haven't reviewed yet, just asking devil's advocate questions).

Contributor

mpdehaan commented Nov 26, 2013

Just thinking aloud, do we want to just call this one "zabbix" and try to make the API signature somewhat resemble the nagios module, or no?

(Haven't reviewed yet, just asking devil's advocate questions).

@abulimov

This comment has been minimized.

Show comment
Hide comment
@abulimov

abulimov Nov 27, 2013

Contributor

I've called it zabbix_maintenance because Zappix API is very reach, and in the future there could be, for example, zabbix_host module to create new hosts in Zabbix from Ansible. About module api signature - i've thought about unification with nagios module, but nagios module is able to manage downtime and silence checks, while this zabbix_maintenance module is made for manipulating Zabbix manintenance window for host/group of hosts. So we can't call actions "disable_alert" or "silence", because in Zabbix we are not silencing or disabling alerts. Zabbix can be configured to keep sending alerts while in mainenance mode. And in Zabbix we can disable some triggers for particular host, but this module does not do it.

Contributor

abulimov commented Nov 27, 2013

I've called it zabbix_maintenance because Zappix API is very reach, and in the future there could be, for example, zabbix_host module to create new hosts in Zabbix from Ansible. About module api signature - i've thought about unification with nagios module, but nagios module is able to manage downtime and silence checks, while this zabbix_maintenance module is made for manipulating Zabbix manintenance window for host/group of hosts. So we can't call actions "disable_alert" or "silence", because in Zabbix we are not silencing or disabling alerts. Zabbix can be configured to keep sending alerts while in mainenance mode. And in Zabbix we can disable some triggers for particular host, but this module does not do it.

@cove

This comment has been minimized.

Show comment
Hide comment
@cove

cove Dec 21, 2013

Contributor

@abulimov fyi, we'll be submitting a zabbix_host like module in the next couple of weeks, we're just finishing it up and testing right now.

Contributor

cove commented Dec 21, 2013

@abulimov fyi, we'll be submitting a zabbix_host like module in the next couple of weeks, we're just finishing it up and testing right now.

@cove

This comment has been minimized.

Show comment
Hide comment
@cove

cove Dec 21, 2013

Contributor

@mpdehaan @abulimov re: separate vs. combined modules for Zabbix; I'd agree with abulimov's approach of separate modules, otherwise I think we'd end up with a module with a lot of args and it could be confusing which ones go with which mode the module is in... in the same sense there isn't one aws or gce module for example. my 2c anyway...

Contributor

cove commented Dec 21, 2013

@mpdehaan @abulimov re: separate vs. combined modules for Zabbix; I'd agree with abulimov's approach of separate modules, otherwise I think we'd end up with a module with a lot of args and it could be confusing which ones go with which mode the module is in... in the same sense there isn't one aws or gce module for example. my 2c anyway...

@abulimov

This comment has been minimized.

Show comment
Hide comment
@abulimov

abulimov Dec 21, 2013

Contributor

@cove, zabbix_host module will be great. I hope we'll finally get a full set of zabbix modules to set up complete monitoring environment with Ansible.

Contributor

abulimov commented Dec 21, 2013

@cove, zabbix_host module will be great. I hope we'll finally get a full set of zabbix modules to set up complete monitoring environment with Ansible.

@cove

This comment has been minimized.

Show comment
Hide comment
@cove

cove Feb 17, 2014

Contributor

@abulimov we've submitted our host and group modules in #6034.

Contributor

cove commented Feb 17, 2014

@abulimov we've submitted our host and group modules in #6034.

@jctanner

This comment has been minimized.

Show comment
Hide comment
@jctanner

jctanner Mar 11, 2014

Member

@abulimov and @cove any updates here or is this in the final state?

Member

jctanner commented Mar 11, 2014

@abulimov and @cove any updates here or is this in the final state?

@jctanner jctanner added the needs_info label Mar 11, 2014

@jimi-c

This comment has been minimized.

Show comment
Hide comment
@jimi-c

jimi-c Mar 11, 2014

Member

As noted in #6034, we'll wait until you guys come to a consensus on param names and update your PRs. Thanks!

Member

jimi-c commented Mar 11, 2014

As noted in #6034, we'll wait until you guys come to a consensus on param names and update your PRs. Thanks!

@mpdehaan mpdehaan added the module label Mar 27, 2014

@mpdehaan

This comment has been minimized.

Show comment
Hide comment
@mpdehaan

mpdehaan Mar 29, 2014

Contributor

Hi folks, if you can comment on this and #6034 that would be appreciated. Otherwise this one may get closed soon -- though we would welcome resubmission should things get resolved and figured out.

Thank you!

Contributor

mpdehaan commented Mar 29, 2014

Hi folks, if you can comment on this and #6034 that would be appreciated. Otherwise this one may get closed soon -- though we would welcome resubmission should things get resolved and figured out.

Thank you!

@abulimov

This comment has been minimized.

Show comment
Hide comment
@abulimov

abulimov Mar 29, 2014

Contributor

Well, this module is complete, and we have a consensus with @cove about param names, so I hope this is the final state of this module.

Contributor

abulimov commented Mar 29, 2014

Well, this module is complete, and we have a consensus with @cove about param names, so I hope this is the final state of this module.

@cove

This comment has been minimized.

Show comment
Hide comment
@cove

cove Mar 29, 2014

Contributor

@mpdehaan @abulimov Sorry the delays here are on my end, we should be able to get this wrapped up by end of next week.

Contributor

cove commented Mar 29, 2014

@mpdehaan @abulimov Sorry the delays here are on my end, we should be able to get this wrapped up by end of next week.

@mpdehaan mpdehaan added P4 and removed P4 labels Apr 18, 2014

@mpdehaan mpdehaan added P4 and removed P3 labels Jun 1, 2014

@mpdehaan

This comment has been minimized.

Show comment
Hide comment
@mpdehaan

mpdehaan Jun 1, 2014

Contributor

Seems to have been no activity on this for a while, curious if any further info is available else we will close this in the next sweep.

Contributor

mpdehaan commented Jun 1, 2014

Seems to have been no activity on this for a while, curious if any further info is available else we will close this in the next sweep.

@abulimov

This comment has been minimized.

Show comment
Hide comment
@abulimov

abulimov Jun 1, 2014

Contributor

I don't know what prevents my module from being merged. It's been in production for 6 month now, and I have no problems with it so far.

Contributor

abulimov commented Jun 1, 2014

I don't know what prevents my module from being merged. It's been in production for 6 month now, and I have no problems with it so far.

@cove

This comment has been minimized.

Show comment
Hide comment
@cove

cove Jun 1, 2014

Contributor

I think the thought was that we'd commit this module and the other zabbix modules all at the same time, so if any changes needed to be made between all of them, such as adjustments to the interfaces for consistency, that we wouldn't break any playbooks using an older version.

I've been OOO for a few weeks, but will be back next week, and will commit some fixes to the other modules. Then maybe we can get all the zabbix modules wrapped up, it's taken a lot longer than I expected honestly.

Contributor

cove commented Jun 1, 2014

I think the thought was that we'd commit this module and the other zabbix modules all at the same time, so if any changes needed to be made between all of them, such as adjustments to the interfaces for consistency, that we wouldn't break any playbooks using an older version.

I've been OOO for a few weeks, but will be back next week, and will commit some fixes to the other modules. Then maybe we can get all the zabbix modules wrapped up, it's taken a lot longer than I expected honestly.

@mpdehaan

This comment has been minimized.

Show comment
Hide comment
@mpdehaan

mpdehaan Aug 8, 2014

Contributor

This is now merged for 1.8 devel, apologies on the time windows as we have been prioritizing a giant queue based on some heuristics that didn't favor merging some easy things like this, which we're now correcting. Happy to have this in and thanks all for working on it!

Contributor

mpdehaan commented Aug 8, 2014

This is now merged for 1.8 devel, apologies on the time windows as we have been prioritizing a giant queue based on some heuristics that didn't favor merging some easy things like this, which we're now correcting. Happy to have this in and thanks all for working on it!

@mpdehaan

This comment has been minimized.

Show comment
Hide comment
@mpdehaan

mpdehaan Aug 8, 2014

Contributor

GitHub didn't pick up the merge, so closing this one manually. Thanks!

Contributor

mpdehaan commented Aug 8, 2014

GitHub didn't pick up the merge, so closing this one manually. Thanks!

@mpdehaan mpdehaan closed this Aug 8, 2014

jimi-c pushed a commit that referenced this pull request Dec 6, 2016

@ansibot ansibot added feature and removed feature_pull_request labels Mar 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment