ansible-pull: Add --module-args to expose all SCM module args and deprecate old argument specific CLI options. (#48678) #50829

ju2wheels · 2019-01-12T01:07:51Z

Second PR to complete #48678

SUMMARY

This change adds a generic --module-args parameter that allows ansible-pull to pass parameters to the underlying SCM module used to checkout the repo without requiring the addition of CLI flags specific to options of each SCM module.

All existing CLI options that correspond to a specific SCM module parameter are deprecated and a warning has been added when behavior is being overridden to preserve backwards compatibility.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ansible-pull

ADDITIONAL INFORMATION

ansibot · 2019-01-12T06:27:40Z

The test ansible-test sanity --test pep8 [explain] failed with 14 errors:

lib/ansible/cli/pull.py:103:1: E101 indentation contains mixed spaces and tabs
lib/ansible/cli/pull.py:103:1: W191 indentation contains tabs
lib/ansible/cli/pull.py:103:43: E128 continuation line under-indented for visual indent
lib/ansible/cli/pull.py:104:1: E101 indentation contains mixed spaces and tabs
lib/ansible/cli/pull.py:113:1: E101 indentation contains mixed spaces and tabs
lib/ansible/cli/pull.py:113:1: W191 indentation contains tabs
lib/ansible/cli/pull.py:113:43: E128 continuation line under-indented for visual indent
lib/ansible/cli/pull.py:114:1: W191 indentation contains tabs
lib/ansible/cli/pull.py:114:2: E101 indentation contains mixed spaces and tabs
lib/ansible/cli/pull.py:114:43: E128 continuation line under-indented for visual indent
lib/ansible/cli/pull.py:115:1: E101 indentation contains mixed spaces and tabs
lib/ansible/cli/pull.py:278:63: E127 continuation line over-indented for visual indent
lib/ansible/cli/pull.py:279:63: E127 continuation line over-indented for visual indent
lib/ansible/cli/pull.py:280:63: E127 continuation line over-indented for visual indent

click here for bot help

… args and their equivalent SCM module arguments. (ansible#48678)

…ts will fail anyway) and separate out the test function for the original integration tests. (ansible#48678)

…ible#48678)

…le#48768)

… that dont support the depth parameter and will fall back to full clone. (ansible#48768)

…k we are exceeding max shell string/buffer/command length on some platforms and thats why it was being dumped into a file previously. (ansible#48678)

…res because its not cleaning up git config. (ansible#50578)

…ately when needed. (ansible#48678)

…or depth support. (ansible#48678)

…date the git depth check. (ansible#48678)

… inventory instead of the repo's ansible.cfg and override localhost inventory to set python interpreter like the implicit localhost does. (ansible#48678)

…ctions for ansible-pull. (ansible#48678)

bcoca · 2022-05-11T19:21:38Z

@ju2wheels can you rebase?

ju2wheels force-pushed the feature/48678-ansible-pull branch from 9a9f765 to 437fb85 Compare Jan 12, 2019

ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jan 12, 2019

ju2wheels force-pushed the feature/48678-ansible-pull branch 2 times, most recently from 2888684 to 63d5149 Compare Jan 12, 2019

ju2wheels closed this Jan 12, 2019

ju2wheels reopened this Jan 12, 2019

ju2wheels closed this Jan 14, 2019

ju2wheels reopened this Jan 14, 2019

bcoca approved these changes Jan 14, 2019

View changes

ju2wheels closed this Jan 14, 2019

ju2wheels reopened this Jan 14, 2019

ju2wheels closed this Jan 15, 2019

ju2wheels reopened this Jan 15, 2019

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 15, 2019

bcoca removed the needs_triage Needs a first human triage before being processed. label Jan 15, 2019

bcoca self-assigned this Jan 15, 2019

ansibot removed the core_review In order to be merged, this PR must follow the core review workflow. label Jan 23, 2019

ju2wheels added 13 commits Jun 11, 2019

Add basic initial integration tests for ansible-pull's deprecated CLI…

32470cf

… args and their equivalent SCM module arguments. (ansible#48678)

Add runme.sh args to all ansible-pull calls (if its a problem the tes…

c9eb377

…ts will fail anyway) and separate out the test function for the original integration tests. (ansible#48678)

Add missing repo directory reset which is causing tests to fail. (ans…

8b56d7e

…ible#48678)

Fix the host check condition tests to be less greedy on match. (ansib…

8e8efee

…le#48768)

Update integration tests to account for systems with old git versions…

587b579

… that dont support the depth parameter and will fall back to full clone. (ansible#48768)

Drop passing around the output and pass the file name instead, I thin…

b053f6a

…k we are exceeding max shell string/buffer/command length on some platforms and thats why it was being dumped into a file previously. (ansible#48678)

Disable ANSIBLE_CONFIG on all ansible-pull calls. (ansible#48678)

c6ee8fc

Fix git_config integration which is possibly cause of git clone failu…

7971ac2

…res because its not cleaning up git config. (ansible#50578)

Dont merge stdout/stderr because of async munging, capture them separ…

6a3df3b

…ately when needed. (ansible#48678)

Using stderr is not consistent, switch to using git output to check f…

a022df4

…or depth support. (ansible#48678)

Update remote repo tag to disable cloud-init check in playbook and up…

56e96d5

…date the git depth check. (ansible#48678)

Change the remote inventory/playbook repo to put the transport in the…

fe8c6ca

… inventory instead of the repo's ansible.cfg and override localhost inventory to set python interpreter like the implicit localhost does. (ansible#48678)

Drop unused function arguments from integration test verification fun…

ea5d7b6

…ctions for ansible-pull. (ansible#48678)

ju2wheels force-pushed the feature/48678-ansible-pull branch from 762d0d8 to 19c885e Compare Jun 11, 2019

Fix indent on corrected merged conflict. (ansible#48678)

416d0dc

ju2wheels force-pushed the feature/48678-ansible-pull branch from 19c885e to 416d0dc Compare Jun 11, 2019

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 11, 2019

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 21, 2019

ansibot added the has_issue label Jul 23, 2019

ansibot added the test This PR relates to tests. label Mar 27, 2020

ansibot added collection Related to Ansible Collections work collection:community.general labels Apr 29, 2020

ansibot added pre_azp This PR was last tested before migration to Azure Pipelines. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 6, 2020

ansibot added the source_control Source-control category label Mar 5, 2021

ansibot removed the collection:community.general label May 24, 2021

ansible-pull: Add --module-args to expose all SCM module args and deprecate old argument specific CLI options. (#48678) #50829

ansible-pull: Add --module-args to expose all SCM module args and deprecate old argument specific CLI options. (#48678) #50829

ju2wheels commented Jan 12, 2019

ansibot commented Jan 12, 2019

bcoca commented May 11, 2022

ansible-pull: Add --module-args to expose all SCM module args and deprecate old argument specific CLI options. (#48678) #50829

Are you sure you want to change the base?

ansible-pull: Add --module-args to expose all SCM module args and deprecate old argument specific CLI options. (#48678) #50829

Conversation

ju2wheels commented Jan 12, 2019

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibot commented Jan 12, 2019

bcoca commented May 11, 2022