Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-pull: Add --module-args to expose all SCM module args and deprecate old argument specific CLI options. (#48678) #50829

Open
wants to merge 19 commits into
base: devel
Choose a base branch
from

Conversation

ju2wheels
Copy link

@ju2wheels ju2wheels commented Jan 12, 2019

  • Second PR to complete #48678
SUMMARY

This change adds a generic --module-args parameter that allows ansible-pull to pass parameters to the underlying SCM module used to checkout the repo without requiring the addition of CLI flags specific to options of each SCM module.

All existing CLI options that correspond to a specific SCM module parameter are deprecated and a warning has been added when behavior is being overridden to preserve backwards compatibility.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ansible-pull

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.8 feature needs_rebase needs_revision needs_triage new_contributor support:core labels Jan 12, 2019
@ju2wheels ju2wheels force-pushed the feature/48678-ansible-pull branch from 9a9f765 to 437fb85 Compare Jan 12, 2019
@ansibot ansibot removed the needs_rebase label Jan 12, 2019
@ansibot
Copy link
Contributor

@ansibot ansibot commented Jan 12, 2019

The test ansible-test sanity --test pep8 [explain] failed with 14 errors:

lib/ansible/cli/pull.py:103:1: E101 indentation contains mixed spaces and tabs
lib/ansible/cli/pull.py:103:1: W191 indentation contains tabs
lib/ansible/cli/pull.py:103:43: E128 continuation line under-indented for visual indent
lib/ansible/cli/pull.py:104:1: E101 indentation contains mixed spaces and tabs
lib/ansible/cli/pull.py:113:1: E101 indentation contains mixed spaces and tabs
lib/ansible/cli/pull.py:113:1: W191 indentation contains tabs
lib/ansible/cli/pull.py:113:43: E128 continuation line under-indented for visual indent
lib/ansible/cli/pull.py:114:1: W191 indentation contains tabs
lib/ansible/cli/pull.py:114:2: E101 indentation contains mixed spaces and tabs
lib/ansible/cli/pull.py:114:43: E128 continuation line under-indented for visual indent
lib/ansible/cli/pull.py:115:1: E101 indentation contains mixed spaces and tabs
lib/ansible/cli/pull.py:278:63: E127 continuation line over-indented for visual indent
lib/ansible/cli/pull.py:279:63: E127 continuation line over-indented for visual indent
lib/ansible/cli/pull.py:280:63: E127 continuation line over-indented for visual indent

click here for bot help

@ju2wheels ju2wheels force-pushed the feature/48678-ansible-pull branch 2 times, most recently from 2888684 to 63d5149 Compare Jan 12, 2019
@ju2wheels ju2wheels closed this Jan 12, 2019
@ju2wheels ju2wheels reopened this Jan 12, 2019
@ansibot ansibot added core_review needs_revision and removed needs_revision core_review labels Jan 12, 2019
@ju2wheels ju2wheels closed this Jan 14, 2019
@ju2wheels ju2wheels reopened this Jan 14, 2019
bcoca
bcoca approved these changes Jan 14, 2019
@ju2wheels ju2wheels closed this Jan 14, 2019
@ju2wheels ju2wheels reopened this Jan 14, 2019
@ju2wheels ju2wheels closed this Jan 15, 2019
@ju2wheels ju2wheels reopened this Jan 15, 2019
@ansibot ansibot added core_review and removed needs_revision labels Jan 15, 2019
@bcoca bcoca removed the needs_triage label Jan 15, 2019
@bcoca bcoca self-assigned this Jan 15, 2019
@ansibot ansibot removed the core_review label Jan 23, 2019
ju2wheels added 13 commits Jun 11, 2019
…ts will fail anyway) and separate out the test function for the original integration tests. (ansible#48678)
… that dont support the depth parameter and will fall back to full clone. (ansible#48768)
…k we are exceeding max shell string/buffer/command length on some platforms and thats why it was being dumped into a file previously. (ansible#48678)
… inventory instead of the repo's ansible.cfg and override localhost inventory to set python interpreter like the implicit localhost does. (ansible#48678)
@ju2wheels ju2wheels force-pushed the feature/48678-ansible-pull branch from 762d0d8 to 19c885e Compare Jun 11, 2019
@ju2wheels ju2wheels force-pushed the feature/48678-ansible-pull branch from 19c885e to 416d0dc Compare Jun 11, 2019
@ansibot ansibot removed the stale_ci label Jun 11, 2019
@ansibot ansibot added the stale_ci label Jun 21, 2019
@ansibot ansibot added needs_rebase needs_revision and removed core_review labels Aug 16, 2019
@ansibot ansibot added the test label Mar 27, 2020
@ansibot ansibot added collection collection:community.general labels Apr 29, 2020
@ansibot ansibot added pre_azp and removed stale_ci labels Dec 6, 2020
@ansibot ansibot added the source_control label Mar 5, 2021
@bcoca
Copy link
Member

@bcoca bcoca commented May 11, 2022

@ju2wheels can you rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.8 collection feature has_issue needs_rebase needs_revision new_contributor pre_azp source_control support:community support:core test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants