PicOS network modules #51418

bw957 · 2019-01-29T07:55:02Z

SUMMARY

picos_facts is the first of PicOS modules to be submitted

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

picos_facts

ADDITIONAL INFORMATION

Added following files:
ansible/lib/ansible/modules/network/picos/init.py
ansible/lib/ansible/modules/network/picos/picos_facts.py
ansible/lib/ansible/module_utils/network/picos/init.py
ansible/lib/ansible/module_utils/network/picos/picos.py
ansible/test/units/modules/network/picos/init.py
ansible/test/units/modules/network/picos/picos_module.py
ansible/test/units/modules/network/picos/test_picos_facts.py
ansible/test/units/modules/network/picos/fixtures/cat_sys_class_swmon_hwinfo_serial_number
ansible/test/units/modules/network/picos/fixtures/hostname
ansible/test/units/modules/network/picos/fixtures/license_s
ansible/test/units/modules/network/picos/fixtures/version
added entry in
ansible/docs/docsite/rst/dev_guide/developing_module_utilities.rst

ansibot · 2019-01-29T07:59:00Z

cc @NilashishC @Qalthos @acozine @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

ansibot · 2019-01-29T07:59:01Z

@bw957, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

ansibot · 2019-01-29T08:12:18Z

The test ansible-test sanity --test pylint [explain] failed with 9 errors:

lib/ansible/module_utils/network/picos/__init__.py:1:0: trailing-newlines Trailing newlines
lib/ansible/module_utils/network/picos/picos.py:51:83: bad-whitespace No space allowed around keyword argument assignment def run_command(module, command_list, command_string, command_pattern, description = ''):                                                                                    ^
lib/ansible/module_utils/network/picos/picos.py:64:40: trailing-whitespace Trailing whitespace
lib/ansible/module_utils/network/picos/picos.py:75:20: undefined-variable Undefined variable 'commans'
lib/ansible/modules/network/picos/__init__.py:1:0: trailing-newlines Trailing newlines
test/units/modules/network/picos/__init__.py:1:0: trailing-newlines Trailing newlines
test/units/modules/network/picos/test_picos_facts.py:24:0: multiple-imports Multiple imports on one line (json, re)
test/units/modules/network/picos/test_picos_facts.py:57:0: anomalous-backslash-in-string Anomalous backslash in string: '\W'. String constant might be missing an r prefix.
test/units/modules/network/picos/test_picos_facts.py:84:55: bad-whitespace Exactly one space required after comma         set_module_args(dict(gather_subset=['-hardware','-config']))                                                        ^

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/network/picos/__init__.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/network/picos/__init__.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test empty-init [explain] failed with 3 errors:

lib/ansible/module_utils/network/picos/__init__.py:0:0: empty __init__.py required
lib/ansible/modules/network/picos/__init__.py:0:0: empty __init__.py required
test/units/modules/network/picos/__init__.py:0:0: empty __init__.py required

The test ansible-test sanity --test pep8 [explain] failed with 12 errors:

lib/ansible/module_utils/network/picos/__init__.py:1:1: W391 blank line at end of file
lib/ansible/module_utils/network/picos/picos.py:44:5: E265 block comment should start with '# '
lib/ansible/module_utils/network/picos/picos.py:51:83: E251 unexpected spaces around keyword / parameter equals
lib/ansible/module_utils/network/picos/picos.py:51:85: E251 unexpected spaces around keyword / parameter equals
lib/ansible/module_utils/network/picos/picos.py:64:41: W291 trailing whitespace
lib/ansible/modules/network/picos/__init__.py:1:1: W391 blank line at end of file
test/units/modules/network/picos/__init__.py:1:1: W391 blank line at end of file
test/units/modules/network/picos/picos_module.py:31:1: E303 too many blank lines (3)
test/units/modules/network/picos/test_picos_facts.py:24:12: E401 multiple imports on one line
test/units/modules/network/picos/test_picos_facts.py:56:17: E265 block comment should start with '# '
test/units/modules/network/picos/test_picos_facts.py:57:18: W605 invalid escape sequence '\W'
test/units/modules/network/picos/test_picos_facts.py:84:56: E231 missing whitespace after ','

The test ansible-test sanity --test shebang [explain] failed with 1 error:

lib/ansible/module_utils/network/picos/picos.py:0:0: should not have a shebang

click here for bot help

ansibot · 2019-01-30T00:34:39Z

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

lib/ansible/module_utils/network/picos/__init__.py:1:0: trailing-newlines Trailing newlines
lib/ansible/module_utils/network/picos/picos.py:75:20: undefined-variable Undefined variable 'commans'
lib/ansible/modules/network/picos/__init__.py:1:0: trailing-newlines Trailing newlines
test/units/modules/network/picos/__init__.py:1:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/network/picos/__init__.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/network/picos/__init__.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test empty-init [explain] failed with 3 errors:

lib/ansible/module_utils/network/picos/__init__.py:0:0: empty __init__.py required
lib/ansible/modules/network/picos/__init__.py:0:0: empty __init__.py required
test/units/modules/network/picos/__init__.py:0:0: empty __init__.py required

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/module_utils/network/picos/__init__.py:1:1: W391 blank line at end of file
lib/ansible/modules/network/picos/__init__.py:1:1: W391 blank line at end of file
test/units/modules/network/picos/__init__.py:1:1: W391 blank line at end of file

click here for bot help

ansibot · 2019-01-30T03:27:08Z

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/module_utils/network/picos/picos.py:75:20: undefined-variable Undefined variable 'commans'
lib/ansible/modules/network/picos/__init__.py:1:0: trailing-newlines Trailing newlines
test/units/modules/network/picos/__init__.py:1:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/network/picos/__init__.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/network/picos/__init__.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test empty-init [explain] failed with 2 errors:

lib/ansible/modules/network/picos/__init__.py:0:0: empty __init__.py required
test/units/modules/network/picos/__init__.py:0:0: empty __init__.py required

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/picos/picos_facts.py:109:0: ImportError: No module named picos.picos

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/picos/picos_facts.py:109:0: ImportError: No module named picos.picos

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/network/picos/__init__.py:1:1: W391 blank line at end of file
test/units/modules/network/picos/__init__.py:1:1: W391 blank line at end of file

click here for bot help

ansibot · 2019-01-30T04:13:17Z

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

lib/ansible/module_utils/network/picos/__init__.py:1:0: trailing-newlines Trailing newlines
lib/ansible/module_utils/network/picos/picos.py:75:20: undefined-variable Undefined variable 'commans'
lib/ansible/modules/network/picos/__init__.py:1:0: trailing-newlines Trailing newlines
test/units/modules/network/picos/__init__.py:1:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/network/picos/__init__.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/network/picos/__init__.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test empty-init [explain] failed with 3 errors:

lib/ansible/module_utils/network/picos/__init__.py:0:0: empty __init__.py required
lib/ansible/modules/network/picos/__init__.py:0:0: empty __init__.py required
test/units/modules/network/picos/__init__.py:0:0: empty __init__.py required

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/module_utils/network/picos/__init__.py:1:1: W391 blank line at end of file
lib/ansible/modules/network/picos/__init__.py:1:1: W391 blank line at end of file
test/units/modules/network/picos/__init__.py:1:1: W391 blank line at end of file

click here for bot help

ansibot · 2019-01-30T04:36:04Z

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/module_utils/network/picos/picos.py:75:20: undefined-variable Undefined variable 'commans'

click here for bot help

bw957 · 2019-01-30T18:12:03Z

@ansiblegalaxy @anotherjesse @jvantuyl
I am a first time contributor and still in learning process. I am not sure what is next. I noticed it has labels core_review and needs_triage. Is this review scheduled by Ansibullbot? Do I need to do anything, or just wait? By the way, it says "use command bot_status", how do I issue such a command? On this page or somewhere else?
Thanks a lot for your help!

ansibot · 2019-01-30T18:18:02Z

Components

docs/docsite/rst/dev_guide/developing_module_utilities.rst
support: core
maintainers: acozine

lib/ansible/module_utils/network/picos/init.py
support: community
maintainers:

lib/ansible/module_utils/network/picos/picos.py
support: community
maintainers:

lib/ansible/modules/network/picos/init.py
support: community
maintainers:

lib/ansible/modules/network/picos/picos_facts.py
support: community
maintainers:

test/units/modules/network/picos/init.py
support: core
maintainers: NilashishC Qalthos ganeshrn gdpak justjais rcarrillocruz trishnaguha

test/units/modules/network/picos/fixtures/cat_sys_class_swmon_hwinfo_serial_number
support: core
maintainers: NilashishC Qalthos ganeshrn gdpak justjais rcarrillocruz trishnaguha

test/units/modules/network/picos/fixtures/hostname
support: core
maintainers: NilashishC Qalthos ganeshrn gdpak justjais rcarrillocruz trishnaguha

test/units/modules/network/picos/fixtures/license_s
support: core
maintainers: NilashishC Qalthos ganeshrn gdpak justjais rcarrillocruz trishnaguha

test/units/modules/network/picos/fixtures/version
support: core
maintainers: NilashishC Qalthos ganeshrn gdpak justjais rcarrillocruz trishnaguha

test/units/modules/network/picos/picos_module.py
support: core
maintainers: NilashishC Qalthos ganeshrn gdpak justjais rcarrillocruz trishnaguha

test/units/modules/network/picos/test_picos_facts.py
support: core
maintainers: NilashishC Qalthos ganeshrn gdpak justjais rcarrillocruz trishnaguha

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

ansibot · 2019-04-28T21:14:24Z

cc @gundalow
click here for bot help

ansibot · 2019-06-23T22:54:52Z

cc @danielmellado
click here for bot help

abenokraitis · 2020-02-11T19:49:18Z

@bw957 Yikes, looks like this fell through the cracks. Unfortunately we are no longer accepting new content submissions into the Ansible project, but instead you should create an Ansible Content Collection and publish it on Ansible Galaxy.

Developing a Collection: https://docs.ansible.com/ansible/latest/dev_guide/developing_collections.html#developing-collections

Creating a Galaxy namespace: https://galaxy.ansible.com/docs/contributing/namespaces.html

Hope this helps!

bw957 added 14 commits January 28, 2019 09:41

Create picos_facts.py

958a8a3

Create __init__.py

0674b6e

Create __init__.py

15c73a2

Create picos.py

508c5b7

Create picos_module.py

fd2244d

Create __init__.py

1b8d572

Create cat_sys_class_swmon_hwinfo_serial_number

ec3994f

Create hostname

dfa09a0

Create cat license_s

6346ff0

Delete cat license_s

d825775

Create license_s

8ef83c7

Create version

b56dee9

Update developing_module_utilities.rst

e810dea

Create test_picos_facts.py

39e6b19

ansibot removed the core_review In order to be merged, this PR must follow the core review workflow. label Jan 29, 2019

Update picos.py

c65b7e0

Delete __init__.py

dc7b03e

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jan 30, 2019

Create __init__.py

4ff4a87

ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jan 30, 2019

make __init__.py empty

4d1d862

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jan 30, 2019

make __init__.py empty

2c63457

ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jan 30, 2019

update picos.py

3f8f569

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 30, 2019

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 7, 2019

ansibot added the docsite This issue/PR relates to the documentation website. label Apr 28, 2019

abenokraitis closed this Feb 11, 2020

sivel removed the needs_triage Needs a first human triage before being processed. label Feb 17, 2020

ansible locked and limited conversation to collaborators Mar 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PicOS network modules #51418

PicOS network modules #51418

bw957 commented Jan 29, 2019

ansibot commented Jan 29, 2019

ansibot commented Jan 29, 2019

ansibot commented Jan 29, 2019

ansibot commented Jan 30, 2019

ansibot commented Jan 30, 2019

ansibot commented Jan 30, 2019

ansibot commented Jan 30, 2019

bw957 commented Jan 30, 2019

ansibot commented Jan 30, 2019

ansibot commented Apr 28, 2019

ansibot commented Jun 23, 2019

abenokraitis commented Feb 11, 2020

PicOS network modules #51418

PicOS network modules #51418

Conversation

bw957 commented Jan 29, 2019

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibot commented Jan 29, 2019

ansibot commented Jan 29, 2019

ansibot commented Jan 29, 2019

ansibot commented Jan 30, 2019

ansibot commented Jan 30, 2019

ansibot commented Jan 30, 2019

ansibot commented Jan 30, 2019

bw957 commented Jan 30, 2019

ansibot commented Jan 30, 2019

Components

Metadata

ansibot commented Apr 28, 2019

ansibot commented Jun 23, 2019

abenokraitis commented Feb 11, 2020