Please make the build reproducible #51419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
|
(Force-pushed to drop one of the patches after rebasing from a |
lamby
force-pushed
the
reproducible-build
branch
from
5f3ac5e
to
b619241
Compare
ansibot
added
small_patch
and removed
needs_rebase
This comment has been minimized.
This comment has been minimized.
lamby
force-pushed
the
reproducible-build
branch
from
b619241
to
ff198a5
Compare
This comment has been minimized.
This comment has been minimized.
lamby
force-pushed
the
reproducible-build
branch
from
ff198a5
to
223f0d5
Compare
bcoca
removed
the
needs_triage
|
@lamby What artifacts are you producing to assert the build is reproducible? Python dist tarball, rpm, deb, ? I'm not sure we can really accept this without some sort of ability to verify the behavior on our side as well. needs_info |
ansibot
added
the
needs_info
ansibot
removed
the
needs_info
ansibot
added
core_review
bcoca
added a commit
to bcoca/ansible
that referenced
this pull request
Feb 18, 2019
alternate to ansible#51419
ansibot
removed
the
core_review
ansibot
added
needs_rebase
|
I'm removing the |
|
This was already resolved by #51453 If you are still having problems, please submit a new issue. If you have further questions please stop by IRC or the mailing list:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort, we noticed that ansible could not be built reproducibly, mostly due to variations in the documentation between successive builds.
This pull request includes a number of changes to make it build in a determinstic manner. Currently it still varies a bit even with this patch, presumably due to nondetermistic filesystem ordering but it will be easier to see after these are merged.