Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove non-standard GetManagerAttributes, SetManagerAttributes #51898

Merged
merged 1 commit into from Feb 11, 2019
Merged

remove non-standard GetManagerAttributes, SetManagerAttributes #51898

merged 1 commit into from Feb 11, 2019

Conversation

billdodd
Copy link
Contributor

@billdodd billdodd commented Feb 7, 2019

SUMMARY

The commands GetManagerAttributes and SetManagerAttributes reply on an Attributes property in the Manager resource. But this is not a standard property in the Redfish spec; it is a vendor-specific Oem property. Accordingly, these 2 non-standard commands are being removed with this PR. These commands can be added by a vendor in an appropriate Oem extension module if needed.

Fixes #47590

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

redfish_utils.py
redfish_facts.py
redfish_config.py

ADDITIONAL INFORMATION

See issue #47590 for the original behavior. After this PR, the subject commands (GetManagerAttributes and SetManagerAttributes) will no longer be available in the standard modules.

@ansibot
Copy link
Contributor

ansibot commented Feb 7, 2019

cc @jose-delarosa @mraineri @tomasg2012
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html support:community This issue/PR relates to code supported by the Ansible community. labels Feb 7, 2019
@mraineri
Copy link

mraineri commented Feb 8, 2019

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Feb 8, 2019
@gundalow gundalow merged commit 3b20b18 into ansible:devel Feb 11, 2019
@gundalow
Copy link
Contributor

@billdodd Thank you for the fix
@mraineri Thank you for the review
Merged into devel for release in Ansible 2.8

Although this is a bug fix I'm not sure if it should be backported to stable-2.7 as it's removing an option.

@billdodd @mraineri Would welcome your thoughts on this.
If you think it is good please raise a backport PR including a changelog/fragment file https://docs.ansible.com/ansible/devel/community/development_process.html#making-your-pr-merge-worthy

@billdodd
Copy link
Contributor Author

Thanks, @gundalow. Since those commands are not using standard Redfish, I do think it makes sense to backport the change to 2.7. Do you agree, @mraineri?

@jose-delarosa - I'm assuming you will likely add those 2 commands into the iDRAC OEM extension module.

@jose-delarosa
Copy link
Contributor

Yup will add 2 commands to the idrac_redfish modules.

billdodd added a commit to billdodd/ansible that referenced this pull request Feb 12, 2019
@billdodd
remove non-standard GetManagerAttributes, SetManagerAttributes (ansib…
930e286 
…le#51898)

(cherry picked from commit 3b20b18)
abadger pushed a commit that referenced this pull request Mar 19, 2019
@billdodd @abadger
Backport/2.7/51898 (#52100)
1d55f4a 
* remove non-standard GetManagerAttributes, SetManagerAttributes (#51898)

(cherry picked from commit 3b20b18)

* add changelog fragment

* fix merge error in default Manager command

* add back {Get/Set}ManagerAttributes commands and deprecate them
This was referenced Mar 25, 2019
Merged
Merged
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redfish_facts fails on GetManagerAttributes
5 participants
@billdodd @ansibot @mraineri @gundalow @jose-delarosa