handle yum/dnf group long form names without @ #51907

maxamillion · 2019-02-07T21:08:12Z

Signed-off-by: Adam Miller admiller@redhat.com

SUMMARY

We were throwing a failure if a package name contained a space, but this breaks backwards compatibility.

Fixes #51888

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

yum
dnf

ansibot · 2019-02-07T21:17:51Z

cc @Akasurde @DJMuggs @berenddeschouwer @ignatenkobrain @kustodian @verm666
click here for bot help

ansibot · 2019-02-07T21:51:28Z

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:0: syntax-error invalid syntax (&lt;unknown&gt;, line 772)

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 774, in <module>
    main()
  File "../bin/plugin_formatter.py", line 729, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 294, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 103, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 40, in read_docstring
    M = ast.parse(b_module_data.read())
  File "/usr/lib/python3.6/ast.py", line 35, in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
  File "<unknown>", line 772
    if '/' in name and (not name.startswith("@"):
                                                ^
SyntaxError: invalid syntax
make: *** [modules] Error 1

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: if '/' in name and (not name.startswith("@"):

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: if '/' in name and (not name.startswith("@"):

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: if '/' in name and (not name.startswith("@"):

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: if '/' in name and (not name.startswith("@"):

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: if '/' in name and (not name.startswith("@"):

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: invalid syntax

The test ansible-test sanity --test pep8 [explain] failed with 144 errors:

lib/ansible/modules/packaging/os/dnf.py:773:21: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:773:29: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:773:31: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:774:21: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:775:25: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:776:25: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:778:17: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:779:21: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:780:21: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:780:41: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:780:43: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:782:17: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:782:38: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:782:40: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:784:17: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:785:21: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:785:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:785:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:786:21: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:790:17: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:792:13: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:794:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:796:5: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:797:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:797:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:810:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:816:5: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:818:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:818:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:820:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:820:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:830:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:846:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:848:5: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:850:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:850:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:851:29: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:851:31: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:858:5: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:859:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:859:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:861:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:861:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:866:9: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:870:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:870:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:875:9: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:880:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:880:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:881:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:881:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:887:40: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:887:42: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:890:60: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:890:62: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:892:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:892:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:893:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:893:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:894:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:894:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:895:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:895:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:897:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:897:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:901:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:901:34: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:908:25: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:931:29: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:936:50: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:936:52: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:942:48: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:942:50: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:954:48: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:954:50: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:964:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:968:34: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:968:36: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:973:39: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:973:41: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1001:29: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1011:58: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1011:60: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1027:48: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1027:50: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1032:34: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1032:36: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1039:44: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1039:46: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1040:39: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1040:41: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1053:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1071:29: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1095:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1095:28: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1102:30: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1102:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1110:44: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1110:46: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1113:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1113:34: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1116:36: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1116:38: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1118:44: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1118:46: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1121:36: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1121:38: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1130:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1144:44: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1144:46: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1148:36: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1148:38: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1152:36: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1152:38: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1156:40: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1156:42: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1159:5: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:1160:5: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:1163:5: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:1172:17: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1175:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1175:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1178:13: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1184:13: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1190:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1190:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1193:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1193:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1196:13: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1205:17: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1206:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1206:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1209:13: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1212:33: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1212:35: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1217:1: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:1229:11: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1229:13: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1231:5: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1233:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1233:28: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1242:9: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1245:1: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:1247:1: E901 TokenError: EOF in multi-line statement

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:0:0: E401 Python SyntaxError while parsing module

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: python-syntax-error invalid syntax (<unknown>, line 772)

click here for bot help

ansibot · 2019-02-07T23:48:15Z

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:0: syntax-error invalid syntax (&lt;unknown&gt;, line 772)

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 774, in <module>
    main()
  File "../bin/plugin_formatter.py", line 729, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 294, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 103, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 40, in read_docstring
    M = ast.parse(b_module_data.read())
  File "/usr/lib/python3.6/ast.py", line 35, in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
  File "<unknown>", line 772
    if '/' in name and (not name.startswith("@"):
                                                ^
SyntaxError: invalid syntax
make: *** [modules] Error 1

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: if '/' in name and (not name.startswith("@"):

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: if '/' in name and (not name.startswith("@"):

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: if '/' in name and (not name.startswith("@"):

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: if '/' in name and (not name.startswith("@"):

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: if '/' in name and (not name.startswith("@"):

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: SyntaxError: invalid syntax

The test ansible-test sanity --test pep8 [explain] failed with 144 errors:

lib/ansible/modules/packaging/os/dnf.py:773:21: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:773:29: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:773:31: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:774:21: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:775:25: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:776:25: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:778:17: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:779:21: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:780:21: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:780:41: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:780:43: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:782:17: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:782:38: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:782:40: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:784:17: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:785:21: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:785:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:785:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:786:21: E128 continuation line under-indented for visual indent
lib/ansible/modules/packaging/os/dnf.py:790:17: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:792:13: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:794:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:796:5: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:797:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:797:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:810:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:816:5: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:818:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:818:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:820:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:820:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:830:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:846:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:848:5: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:850:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:850:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:851:29: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:851:31: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:858:5: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:859:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:859:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:861:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:861:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:866:9: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:870:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:870:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:875:9: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:880:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:880:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:881:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:881:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:887:40: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:887:42: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:890:60: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:890:62: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:892:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:892:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:893:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:893:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:894:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:894:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:895:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:895:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:897:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:897:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:901:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:901:34: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:908:25: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:931:29: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:936:50: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:936:52: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:942:48: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:942:50: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:954:48: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:954:50: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:964:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:968:34: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:968:36: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:973:39: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:973:41: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1001:29: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1011:58: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1011:60: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1027:48: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1027:50: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1032:34: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1032:36: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1039:44: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1039:46: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1040:39: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1040:41: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1053:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1071:29: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1095:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1095:28: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1102:30: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1102:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1110:44: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1110:46: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1113:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1113:34: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1116:36: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1116:38: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1118:44: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1118:46: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1121:36: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1121:38: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1130:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1144:44: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1144:46: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1148:36: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1148:38: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1152:36: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1152:38: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1156:40: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1156:42: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1159:5: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:1160:5: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:1163:5: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:1172:17: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1175:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1175:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1178:13: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1184:13: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1190:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1190:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1193:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1193:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1196:13: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1205:17: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1206:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1206:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1209:13: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1212:33: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1212:35: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1217:1: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:1229:11: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1229:13: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1231:5: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1233:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1233:28: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/dnf.py:1242:9: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/os/dnf.py:1245:1: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/dnf.py:1247:1: E901 TokenError: EOF in multi-line statement

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:0:0: E401 Python SyntaxError while parsing module

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:772:61: python-syntax-error invalid syntax (<unknown>, line 772)

click here for bot help

mkrizek · 2019-02-08T09:19:50Z

lib/ansible/modules/packaging/os/dnf.py

                # like "dnf install /usr/bin/vi"
-                if '/' in name:
+                if '/' in name and (not name.startswith("@"):


Missing closing parenthesis.

OMG of course I am ... sigh

Thanks

mkrizek

Except the syntax error, looks good to me 👍

mkrizek · 2019-03-13T07:59:44Z

Looks like we need to do (or replace or something):

diff --git a/lib/ansible/modules/packaging/os/dnf.py b/lib/ansible/modules/packaging/os/dnf.py
index 1597af2eb1..25f0125ef8 100644
--- a/lib/ansible/modules/packaging/os/dnf.py
+++ b/lib/ansible/modules/packaging/os/dnf.py
@@ -787,7 +787,10 @@ class DnfModule(YumDnf):
                     self.base.read_comps()
                     already_loaded_comps = True
 
-                grp_env_mdl_candidate = name[1:].strip()
+                if '@' in name:
+                    grp_env_mdl_candidate = name[1:].strip()
+                else:
+                    grp_env_mdl_candidate = name.strip()
 
                 if self.with_modules:
                     mdl = self.module_base._get_modules(grp_env_mdl_candidate)

Fixes ansible#51888 Signed-off-by: Adam Miller <admiller@redhat.com>

Signed-off-by: Adam Miller <admiller@redhat.com>

maxamillion requested a review from mkrizek February 7, 2019 21:08

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 7, 2019

mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 7, 2019

ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed needs_triage Needs a first human triage before being processed. ci_verified Changes made in this PR are causing tests to fail. labels Feb 7, 2019

jborean93 added the ci_verified Changes made in this PR are causing tests to fail. label Feb 8, 2019

mkrizek reviewed Feb 8, 2019

View reviewed changes

mkrizek approved these changes Feb 8, 2019

View reviewed changes

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 9, 2019

mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 14, 2019

ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html packaging Packaging category labels Feb 14, 2019

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 22, 2019

maxamillion force-pushed the bugfix/51888-yum-groupinstall-spaces-in-name branch from 3124025 to 390d62e Compare March 7, 2019 22:47

ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 7, 2019

mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Mar 13, 2019

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 21, 2019

ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Apr 14, 2019

maxamillion force-pushed the bugfix/51888-yum-groupinstall-spaces-in-name branch from 390d62e to e9685d0 Compare July 22, 2019 20:16

ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 22, 2019

mkrizek mentioned this pull request Jul 23, 2019

dnf allowerasing #48319

Merged

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 30, 2019

goneri added the ci_verified Changes made in this PR are causing tests to fail. label Oct 2, 2019

maxamillion added 4 commits November 6, 2019 15:16

handle yum/dnf group long form names without @

ab7276a

Fixes ansible#51888 Signed-off-by: Adam Miller <admiller@redhat.com>

add changelog fragment

f205096

Signed-off-by: Adam Miller <admiller@redhat.com>

fix typo's that caused syntax errors

1483ca4

Signed-off-by: Adam Miller <admiller@redhat.com>

properly handle grp_env_mdl_candidate name with/without @

5d84904

Signed-off-by: Adam Miller <admiller@redhat.com>

maxamillion force-pushed the bugfix/51888-yum-groupinstall-spaces-in-name branch from e9685d0 to 5d84904 Compare November 6, 2019 23:28

ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 6, 2019

mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Nov 7, 2019

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Nov 15, 2019

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 23, 2019

mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jan 9, 2020

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 9, 2020

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 17, 2020

ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label May 16, 2020

ansibot added pre_azp This PR was last tested before migration to Azure Pipelines. and removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 5, 2020

ansibot removed the support:community This issue/PR relates to code supported by the Ansible community. label Mar 5, 2021

s-hertel added the P3 Priority 3 - Approved, No Time Limitation label Mar 5, 2021

handle yum/dnf group long form names without @ #51907

handle yum/dnf group long form names without @ #51907

maxamillion commented Feb 7, 2019

ansibot commented Feb 7, 2019

ansibot commented Feb 7, 2019

ansibot commented Feb 7, 2019

mkrizek Feb 8, 2019

maxamillion Feb 9, 2019

mkrizek left a comment

mkrizek commented Mar 13, 2019

handle yum/dnf group long form names without @ #51907

Are you sure you want to change the base?

handle yum/dnf group long form names without @ #51907

Conversation

maxamillion commented Feb 7, 2019

SUMMARY

ISSUE TYPE

COMPONENT NAME

ansibot commented Feb 7, 2019

ansibot commented Feb 7, 2019

ansibot commented Feb 7, 2019

mkrizek Feb 8, 2019

Choose a reason for hiding this comment

maxamillion Feb 9, 2019

Choose a reason for hiding this comment

mkrizek left a comment

Choose a reason for hiding this comment

mkrizek commented Mar 13, 2019