Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluribus Networks system settings module with UT #52065

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@rajaspachipulusu17
Copy link
Contributor

rajaspachipulusu17 commented Feb 12, 2019

SUMMARY

Point feature of system settings for Pluribus Networks Netvisor switches

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

pn_system_settings.py module with unit tests.

ADDITIONAL INFORMATION

ansible 2.4.0.0
config file = None
configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /usr/local/lib/python2.7/dist-packages/ansible
executable location = /usr/local/bin/ansible
python version = 2.7.12 (default, Dec 4 2017, 14:50:18) [GCC 5.4.0 20160609]

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 12, 2019

@rajaspachipulusu17, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 12, 2019

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/network/netvisor/pn_system_settings.py:370:33: undefined-variable Undefined variable 'switch'
lib/ansible/modules/network/netvisor/pn_system_settings.py:379:59: undefined-variable Undefined variable 'action'
lib/ansible/modules/network/netvisor/pn_system_settings.py:386:59: undefined-variable Undefined variable 'action'

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/network/netvisor/pn_system_settings.py:0:0: E305 DOCUMENTATION.version: extra keys not allowed @ data['version']. Got '2.8'
lib/ansible/modules/network/netvisor/pn_system_settings.py:0:0: E305 DOCUMENTATION.version_added: required key not provided @ data['version_added']. Got None
lib/ansible/modules/network/netvisor/pn_system_settings.py:0:0: E307 version_added should be '2.8'. Currently None

click here for bot help

@ansibot ansibot removed the ci_verified label Feb 12, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 12, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/network/netvisor/pn_system_settings.py:0:0: E305 DOCUMENTATION.options.state.choice: extra keys not allowed @ data['options']['state']['choice']. Got ['update']
lib/ansible/modules/network/netvisor/pn_system_settings.py:0:0: E326 Value for "choices" from the argument_spec (['update']) for "state" does not match the documentation ([])

click here for bot help

@ansibot ansibot added the ci_verified label Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.