Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/2.7/51898 #52100

Merged
merged 4 commits into from Mar 19, 2019

Conversation

Projects
None yet
3 participants
@billdodd
Copy link
Contributor

billdodd commented Feb 12, 2019

SUMMARY

The commands GetManagerAttributes and SetManagerAttributes reply on an Attributes property in the Manager resource. But this is not a standard property in the Redfish spec; it is a vendor-specific Oem property. Accordingly, these 2 non-standard commands are being removed with this PR. These commands can be added by a vendor in an appropriate Oem extension module if needed.

Fixes #47590

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

redfish_utils.py
redfish_facts.py
redfish_config.py

ADDITIONAL INFORMATION

See issue #47590 for the original behavior. After this PR, the subject commands (GetManagerAttributes and SetManagerAttributes) will no longer be available in the standard modules.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 12, 2019

@abadger

This comment has been minimized.

Copy link
Member

abadger commented Feb 12, 2019

I do not believe this is eligible for backporting as it is removing module parameters which would break existing playbooks.

to solve the initial bug on the stable release you could make this code conditional such that if the remote does not support the non-standard features we give the user a nice error that says that these parameters cannot be used with this host.

It would also be nice for the users if you added a deprecation warning when they specify the parameters which are going away. That way they can start preparing to change their playbooks in the next release. (via module.deprecate(msg)).

@ansibot ansibot removed the needs_triage label Feb 12, 2019

@billdodd

This comment has been minimized.

Copy link
Contributor Author

billdodd commented Feb 12, 2019

Thanks, @abadger

I will work on a new PR that emits the suggested deprecation warning and a nice error in the case that the non-standard feature is not available.

Is the best/standard practice in this type of scenario to (1) keep this PR open and update it or (2) close this one and open a new one?

@abadger

This comment has been minimized.

Copy link
Member

abadger commented Feb 12, 2019

I think updating the existing PR is probably best. Thanks :-)

@billdodd

This comment has been minimized.

Copy link
Contributor Author

billdodd commented Feb 12, 2019

Sounds good. Thanks for the feedback.

@ansibot ansibot added the stale_ci label Feb 20, 2019

@abadger

This comment has been minimized.

Copy link
Member

abadger commented Mar 18, 2019

@billdodd Hey, just a note that Ansible-2.8.0 will be out in a little over a month. Once that happens, we will only be backporting critical bugfixes to Ansible-2.7.x. So if you want to get this into a 2.7.x release it needs to be done soon.

@billdodd

This comment has been minimized.

Copy link
Contributor Author

billdodd commented Mar 18, 2019

@abadger - thanks for the heads-up. I will try to get this in for 2.7.x soon.

@ansibot ansibot removed the stale_ci label Mar 19, 2019

@abadger abadger merged commit 1d55f4a into ansible:stable-2.7 Mar 19, 2019

1 check passed

Shippable Run 114808 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

abadger commented Mar 19, 2019

Merged for the 2.7.10 release. Thanks!

@billdodd

This comment has been minimized.

Copy link
Contributor Author

billdodd commented Mar 19, 2019

Thanks, @abadger!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.