Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os_image_facts: add ability to filter Openstack images based on prope… #52146

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@pholica
Copy link

pholica commented Feb 13, 2019

…rties

SUMMARY

Currently it's not possible to provision OpenStack instance with image selected based on it's properties, the only options are name and id.
Extending os_image_facts to allow images queries based on their properties allows querying images and provisioning instances with such images based solely on the properties.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

os_image_facts

ADDITIONAL INFORMATION

none


@openstack-zuul

This comment has been minimized.

Copy link

openstack-zuul bot commented Feb 13, 2019

Build succeeded (third-party-check pipeline).

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 13, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_image_facts.py:0:0: E309 version_added for new option (properties) should be '2.8'. Currently StrictVersion ('0.0')

click here for bot help

@openstack-zuul

This comment has been minimized.

Copy link

openstack-zuul bot commented Feb 13, 2019

Build succeeded (third-party-check pipeline).

@JAORMX

JAORMX approved these changes Feb 14, 2019

Copy link
Contributor

JAORMX left a comment

LGTM

@ansibot ansibot added the stale_ci label Feb 22, 2019

@pholica pholica closed this Feb 22, 2019

@pholica pholica reopened this Feb 22, 2019

@ansibot ansibot removed the stale_ci label Feb 22, 2019

@openstack-zuul

This comment has been minimized.

Copy link

openstack-zuul bot commented Feb 22, 2019

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@pholica pholica closed this Feb 25, 2019

@pholica pholica reopened this Feb 25, 2019

@openstack-zuul

This comment has been minimized.

Copy link

openstack-zuul bot commented Feb 25, 2019

Build succeeded (third-party-check pipeline).

@pholica

This comment has been minimized.

Copy link
Author

pholica commented Feb 25, 2019

I'm new to the processes in pull requests for Ansible. I've read the documentation how to submit changes and I believe I did everything that's needed. Is there anything more needed from me to have this merged? If yes, I'd like to know so that I can contribute.

@ansibot ansibot added the stale_ci label Mar 5, 2019

@pholica pholica closed this Mar 5, 2019

@pholica pholica reopened this Mar 5, 2019

@ansibot ansibot removed the stale_ci label Mar 5, 2019

@openstack-zuul

This comment has been minimized.

Copy link

openstack-zuul bot commented Mar 5, 2019

Build succeeded (third-party-check pipeline).

@ansibot ansibot added the stale_ci label Mar 13, 2019

@pholica pholica closed this Mar 18, 2019

@pholica pholica reopened this Mar 18, 2019

@ansibot ansibot removed the stale_ci label Mar 18, 2019

@openstack-zuul

This comment has been minimized.

Copy link

openstack-zuul bot commented Mar 18, 2019

Build succeeded (third-party-check pipeline).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.