Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to run in Privileged mode to Na_ontap_command #52343

Merged
merged 3 commits into from Mar 19, 2019

Conversation

Projects
None yet
6 participants
@carchi8py
Copy link
Contributor

carchi8py commented Feb 15, 2019

SUMMARY

New Option to allow running in privileged mode

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • na_ontap_command.py
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 15, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_command.py:0:0: E309 version_added for new option (privilege) should be '2.8'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot

This comment has been minimized.

@ansibot ansibot added needs_revision and removed core_review labels Feb 16, 2019

@lonico

lonico approved these changes Feb 20, 2019

Copy link
Contributor

lonico left a comment

shipit

@ansibot ansibot added shipit and removed needs_revision labels Feb 20, 2019

@thedoubl3j
Copy link
Contributor

thedoubl3j left a comment

looks good to me, only a small nit pick that isn't a blocker.

def asup_log_for_cserver(self, event_name):
"""
Fetch admin vserver for the given cluster
Create and Autosupport log event with the given module name

This comment has been minimized.

@thedoubl3j

thedoubl3j Mar 19, 2019

Contributor

nit pick and -> an

@gundalow gundalow merged commit 309f7e5 into ansible:devel Mar 19, 2019

1 check passed

Shippable Run 113702 status is SUCCESS.
Details
@gundalow

This comment has been minimized.

Copy link
Contributor

gundalow commented Mar 19, 2019

Merged, thanks.
Typo was just in comment, so I'm OK with this as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.