Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Module na_elementsw_cluster_config #52373

Open
wants to merge 6 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@carchi8py
Copy link
Contributor

carchi8py commented Feb 15, 2019

SUMMARY

New Module na_elementsw_cluster_config -- Configure Clusters in ElementSW

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • na_elementsw_cluster_config
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 15, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_elementsw_cluster_config.py:292:15: undefined-variable Undefined variable 'cmp'

click here for bot help

@ansibot

This comment has been minimized.

@lonico

lonico approved these changes Feb 20, 2019

Copy link
Contributor

lonico left a comment

shipit

@ansibot ansibot added shipit and removed core_review labels Feb 20, 2019

@thedoubl3j
Copy link
Contributor

thedoubl3j left a comment

module looks good, CI is looking good. lgtm

@thedoubl3j

This comment has been minimized.

Copy link
Contributor

thedoubl3j commented Mar 13, 2019

module looks good, CI is looking good. lgtm

a question regarding this though as I am not familiar, would users need to remove things by chance? I am only seeing enable features and or read features. Just wondering

@lonico

This comment has been minimized.

Copy link
Contributor

lonico commented Mar 19, 2019

module looks good, CI is looking good. lgtm

a question regarding this though as I am not familiar, would users need to remove things by chance? I am only seeing enable features and or read features. Just wondering

@thedoubl3j The cluster is created or deleted separately (there is another module). The idea is that the default values are good enough (simplicity) but they can be tweaked if needed.

@thedoubl3j

This comment has been minimized.

Copy link
Contributor

thedoubl3j commented Mar 19, 2019

@lonico gotcha, just wondering. trying to simplify things where we can. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.