Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Module: na_elementsw_cluster_snmp #52374

Open
wants to merge 6 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@carchi8py
Copy link
Contributor

carchi8py commented Feb 15, 2019

SUMMARY

New Module: na_elementsw_cluster_snmp -- Configure cluster SNMP for elementSW

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • na_elementsw_cluster_snmp.py
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 15, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

test/units/modules/storage/netapp/test_na_elementsw_cluster_snmp.py:51:1: E305 expected 2 blank lines after class or function definition, found 1

click here for bot help

@lonico

lonico approved these changes Feb 20, 2019

Copy link
Contributor

lonico left a comment

shipit

@ansibot ansibot added shipit and removed core_review labels Feb 20, 2019

@thedoubl3j
Copy link
Contributor

thedoubl3j left a comment

looks good to me. This isn't a blocker but more just a question, as this module relates directly to clusters of elementsw, would there be any reasoning as to why this wouldn't be a feature of na_elelmentsw_cluster_config? #52373 @carchi8py @lonico

@lonico

This comment has been minimized.

Copy link
Contributor

lonico commented Mar 19, 2019

looks good to me. This isn't a blocker but more just a question, as this module relates directly to clusters of elementsw, would there be any reasoning as to why this wouldn't be a feature of na_elelmentsw_cluster_config? #52373 @carchi8py @lonico

@thedoubl3j Good question. This was a request from the Product Management team. They wanted to single out SNMP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.