Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate-modules: Refactor & fix various modules #52433

Open
wants to merge 1 commit into
base: devel
from

Conversation

@dagwieers
Copy link
Member

dagwieers commented Feb 18, 2019

SUMMARY

This PR fixes:

  • all validate-modules issues with cloud/misc, identity and source_control modules
  • parameter types

Three modules have been modified to the extent that I prefer the maintainer takes a better look and tests the changes.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

Various modules

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 18, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/cloud/misc/ovirt.py:0:0: E309 version_added for new option (instance_gateway) should be '2.8'. Currently StrictVersion ('2.1')
lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E309 version_added for new option (numa_enabled) should be '2.8'. Currently StrictVersion ('0.0')
lib/ansible/modules/cloud/misc/rhevm.py:0:0: E309 version_added for new option (password) should be '2.8'. Currently StrictVersion ('0.0')

click here for bot help

@dagwieers dagwieers force-pushed the dagwieers:validate-modules-various branch from 972ea3b to eb215e4 Feb 18, 2019

@dagwieers

This comment has been minimized.

Copy link
Member Author

dagwieers commented Feb 18, 2019

The CI failure is related to an undocumented parameter that I added.

@nitzmahone
Copy link
Member

nitzmahone left a comment

Thanks for patching those up- looks like a couple of unrelated changes that might not belong, and we probably want to keep the exception returns where present since they can be useful for debugging issues (and only appear on -vvv)

@dagwieers dagwieers force-pushed the dagwieers:validate-modules-various branch 2 times, most recently from efc9f63 to fd9fd7c Feb 18, 2019

@dagwieers dagwieers force-pushed the dagwieers:validate-modules-various branch 2 times, most recently from aab8f5a to 1af64d4 Feb 18, 2019

All comments fixed or resolved.

@gundalow gundalow changed the title validate-modules: Fix various modules validate-modules: Refactor & fix various modules Feb 22, 2019

validate-modules: Fix various modules
This PR fixes:
- all validate-modules issues with cloud/misc, identity and source_control modules
- fix parameter types

@dagwieers dagwieers force-pushed the dagwieers:validate-modules-various branch from 1af64d4 to c754d6e Feb 25, 2019

@dagwieers

This comment has been minimized.

Copy link
Member Author

dagwieers commented Feb 25, 2019

@gundalow @samccann @nitzmahone Please re-review !

@mwperina
Copy link
Contributor

mwperina left a comment

ovirt module changes looks good to me

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 25, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/ovirt.py:0:0: E309 version_added for new option (instance_gateway) should be '2.8'. Currently StrictVersion ('2.1')

click here for bot help

@samccann
Copy link
Contributor

samccann left a comment

docs portion lgtm

@dagwieers dagwieers removed virt labels Feb 28, 2019

@dagwieers

This comment has been minimized.

Copy link
Member Author

dagwieers commented Mar 5, 2019

@gundalow Is this one ready to be merged ?

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.