Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxmox_kvm: Refactor & fix validate-modules issues #52434

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@dagwieers
Copy link
Member

dagwieers commented Feb 18, 2019

SUMMARY

This PR includes:

  • Adding parameter types
  • Fix validate-modules issue
  • Improve parameter types and resulting changes

This PR needs to be verified and tested by maintainer(s).

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

proxmox_kvm

proxmox_kvm: Fix validate-modules issues
This PR includes:
- Adding parameter types
- Fix validate-modules issue
- Improve parameter types and resulting changes

This PR needs to be verified and tested by maintainer(s).
@ansibot

This comment has been minimized.

@dagwieers

This comment has been minimized.

Copy link
Member Author

dagwieers commented Feb 18, 2019

The CI failure is related to an undocumented parameter that I added.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 18, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox_kvm.py:0:0: E309 version_added for new option (numa_enabled) should be '2.8'. Currently StrictVersion ('0.0')

click here for bot help

@dagwieers

This comment has been minimized.

Copy link
Member Author

dagwieers commented Feb 18, 2019

bot_skip

@gundalow gundalow changed the title proxmox_kvm: Fix validate-modules issues proxmox_kvm: Refactor & fix validate-modules issues Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.