Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New na_ontap_volume option #52587

Merged
merged 5 commits into from Mar 22, 2019

Conversation

Projects
None yet
7 participants
@carchi8py
Copy link
Contributor

carchi8py commented Feb 19, 2019

SUMMARY

New options for Volume
• Aggr_list -- array of Aggregates for FlexGroup
• aggr_list_multiplier -- Number of times to iterate over the aggregates
• auto_provision_as -- Automatically provision a flexGroup Volume
• snapdir_access -- enable the visible .snapshot directory
• atime_update -- prevent the update of inode access time when a file is read
• wait_for_completion --
• time_out -- time to wait for flexgroup creation
• language -- Set language of volume

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • na_ontap_volume
ADDITIONAL INFORMATION

carchi8py added some commits Dec 10, 2018

Revert "changes to clusteR"
This reverts commit 33ee1b7.
@ansibot

This comment has been minimized.

@samdoran samdoran removed the needs_triage label Feb 19, 2019

@bcoca bcoca changed the title New option for Volume New na_ontap_volume option Feb 19, 2019

@lonico

lonico approved these changes Feb 20, 2019

Copy link
Contributor

lonico left a comment

ship

@lonico

This comment has been minimized.

Copy link
Contributor

lonico commented Feb 20, 2019

shipit

@ansibot ansibot added shipit and removed core_review labels Feb 20, 2019

@thedoubl3j
Copy link
Contributor

thedoubl3j left a comment

just a few renaming questions in the examples. everything looks relatively clean. a test addition per @gundalow 's request just to make sure things aren't breaking there.

'''

EXAMPLES = """
- name: Create FlexVol
na_ontap_volume:
state: present
name: ansibleVolume
name: ansibleVolume12

This comment has been minimized.

@thedoubl3j

thedoubl3j Mar 6, 2019

Contributor

any particular reason why this got renamed?

This comment has been minimized.

@carchi8py

carchi8py Mar 6, 2019

Author Contributor

We have internal playbook that we use to test out examples. And then we copy and paste them into the example text. I believe with the new option we just ended up using different names. We can change this back to AnsibleVolume if you guys like.

This comment has been minimized.

@thedoubl3j

thedoubl3j Mar 11, 2019

Contributor

all good man, just asking :)

@schmots1
Copy link
Contributor

schmots1 left a comment

shipit

@ansibot ansibot added core_review and removed shipit labels Mar 20, 2019

@lonico

lonico approved these changes Mar 20, 2019

Copy link
Contributor

lonico left a comment

shipit

@ansibot ansibot added shipit and removed core_review labels Mar 20, 2019

@thedoubl3j
Copy link
Contributor

thedoubl3j left a comment

requests addressed, lgtm

@gundalow gundalow merged commit 1e6aa95 into ansible:devel Mar 22, 2019

1 check passed

Shippable Run 115024 status is SUCCESS.
Details
@gundalow

This comment has been minimized.

Copy link
Contributor

gundalow commented Mar 22, 2019

Thanks all, merged into devel for release in Ansible 2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.