Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding hdinsight cluster #52612

Merged
merged 47 commits into from Mar 20, 2019

Conversation

Projects
None yet
5 participants
@zikalino
Copy link
Contributor

zikalino commented Feb 20, 2019

SUMMARY

Adding HDInsight cluster

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_hdinsightcluster

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

zikalino added some commits Feb 20, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 20, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:228:59: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:230:53: W291 trailing whitespace

click here for bot help

zikalino added some commits Feb 20, 2019

zikalino added some commits Mar 4, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 4, 2019

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:308:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:309:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:312:17: E265 block comment should start with '# '

click here for bot help

@ansibot ansibot added the ci_verified label Mar 4, 2019

@ansibot ansibot removed the ci_verified label Mar 4, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 4, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:315:0: syntax-error invalid syntax (<unknown>, line 315)

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 774, in <module>
    main()
  File "../bin/plugin_formatter.py", line 729, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 294, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 105, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 40, in read_docstring
    M = ast.parse(b_module_data.read())
  File "/usr/lib/python3.6/ast.py", line 35, in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
  File "<unknown>", line 315
    self.module.warn("property '" + k "' cannot be updated (" + compare_results[k] + ")")
                                                            ^
SyntaxError: invalid syntax
make: *** [modules] Error 1

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:315:85: SyntaxError: self.module.warn("property '" + k "' cannot be updated (" + compare_results[k] + ")")

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:315:85: SyntaxError: self.module.warn("property '" + k "' cannot be updated (" + compare_results[k] + ")")

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:315:85: SyntaxError: self.module.warn("property '" + k "' cannot be updated (" + compare_results[k] + ")")

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:315:85: SyntaxError: self.module.warn("property '" + k "' cannot be updated (" + compare_results[k] + ")")

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:315:85: SyntaxError: self.module.warn("property '" + k "' cannot be updated (" + compare_results[k] + ")")

The test ansible-test sanity --test compile --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:315:63: SyntaxError: self.module.warn("property '" + k "' cannot be updated (" + compare_results[k] + ")")

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:315:85: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:315:85: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:315:85: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:315:85: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:315:85: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:315:63: SyntaxError: invalid syntax

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:0:0: E401 Python SyntaxError while parsing module

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:315:85: python-syntax-error invalid syntax (<unknown>, line 315)

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 5, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_hdinsightcluster.py:315:90: undefined-variable Undefined variable 'compare_results'

click here for bot help

zikalino added some commits Mar 5, 2019

@Fred-sun

This comment has been minimized.

Copy link
Contributor

Fred-sun commented Mar 13, 2019

@yuwzho @yungezz review_need

@nitzmahone nitzmahone merged commit d71ca02 into ansible:devel Mar 20, 2019

1 check passed

Shippable Run 112144 status is SUCCESS.
Details
@mattclay

This comment has been minimized.

Copy link
Member

mattclay commented Mar 21, 2019

@zikalino I marked this test unstable in #54152 due to tests timing out when executed as a group. I didn't want to mark it unsupported, but I didn't really want to assign it to its own test group either.

@zikalino

This comment has been minimized.

Copy link
Contributor Author

zikalino commented Mar 21, 2019

@mattclay I think it's a good choice
I think we should have some special alias for resources like this, so we could have enabled tests, but in the same time we shouldn't run them too frequently.
another example is aks which is disabled right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.