Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Use local dummy repo for flatpak_remote integration tests #52668
Fixes a problem with the
They relied on the availability of the flathub repository infrastructure. This PR replaces the use of flathub with a local dummy repository.
I was not comfortable with having the integration tests enabled in the Shippable pipeline before removing this dependency, since an outage of flathub would have led to the tests failing. This PR also enables the integration tests in Shippable.
There are however some caveats, that I would need your help assessing. See below.
There are some caveats with my solution though:
The simplest way to provide the dummy repository for me was to build the test apps and repo locally and adding the resulting folder to the
I think that I could generate the repo somehow. It's not completely straight-forward though, since the flatpak build process relies on runtimes hosted externally, for example on flathub. Obviously we do not want to get a dependency on flathub through the back-door here.
Question 1: Is the size of the dummy repo a problem?
Even though I could remove the dependency on flathub, there are some dependencies to external repos left. On the Ansible docker test images for Fedora and Ubuntu 18.04, we have to install the flatpak package. I guess that this is not a problem, since many integration tests rely on installing packages from distro repositories.
On Ubuntu 16.04, however, flatpak is not available, so we need to rely on the official flatpak PPA to install flatpak. We could of course ignore Ubuntu 16.04 for testing. However, testing against the flatpak PPA enables us to test against the latest version of flatpak, which increases our version coverage.
Question 2: Is the dependency on the official flatpak PPA maintained by flatpak creator Alex Larsson a problem?
I am not entirely sure as to what the different shippable posix group numbers mean.
I maybe missing it, though I don't see the tests being run
@gundalow Happy you appreciate the testing.
@mattclay Thanks for your feedback and for helping getting this merged.