Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qradar httpapi plugin #52690

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@maxamillion
Copy link
Contributor

maxamillion commented Feb 20, 2019

Signed-off-by: Adam Miller admiller@redhat.com

SUMMARY

Add httpapi plugin for QRadar SIEM Appliances

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

httpapi
qradar

qradar httpapi plugin
Signed-off-by: Adam Miller <admiller@redhat.com>

@maxamillion maxamillion requested a review from rcarrillocruz Feb 20, 2019

@ansibot

This comment has been minimized.

remove no longer used get_session_uid method
Signed-off-by: Adam Miller <admiller@redhat.com>
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 21, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_vscan_on_demand_task.py:0:0: E325 Argument 'scan_files_with_no_ext' in argument_spec defines type as <class 'bool'> but documentation defines type as 'bool'

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Feb 21, 2019


return response.getcode(), self._response_to_json(value)
except AnsibleConnectionFailure as e:
if to_text('401') in to_text(e):

This comment has been minimized.

@Qalthos

Qalthos Feb 21, 2019

Contributor

You should be able to deal with all of this more sensibly if you override handle_httperror()... see https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/httpapi/__init__.py#L54

@maxamillion

This comment has been minimized.

Copy link
Contributor Author

maxamillion commented Mar 7, 2019

@Qalthos I'm not sure I follow how overriding handle_httperror would help, is there a way to set a custom response message? it looks like httpapi expects that function to return True or False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.