Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ssh key from vault #52739

Draft
wants to merge 40 commits into
base: devel
Choose a base branch
from

Conversation

webknjaz
Copy link
Member

SUMMARY

This lets users share SSH keys using Ansible Vault

Closes #22382

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ssh connection plugin

ADDITIONAL INFORMATION

N/A

@webknjaz webknjaz self-assigned this Feb 21, 2019
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 21, 2019
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Feb 21, 2019
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 23, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 25, 2019
@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed ci_verified Changes made in this PR are causing tests to fail. labels Feb 25, 2019
@webknjaz webknjaz force-pushed the feature/22382-use-ssh-key-from-vault branch from a66f624 to 3f381ed Compare February 27, 2019 14:31
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 28, 2019
@webknjaz webknjaz force-pushed the feature/22382-use-ssh-key-from-vault branch from 3f381ed to 9e27a25 Compare March 5, 2019 15:40
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Mar 5, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Mar 6, 2019
@webknjaz webknjaz force-pushed the feature/22382-use-ssh-key-from-vault branch from 9e27a25 to 5569743 Compare March 6, 2019 19:23
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Mar 6, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Mar 6, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Mar 7, 2019
@ansibot

This comment has been minimized.

@ansibot ansibot added the test This PR relates to tests. label Mar 7, 2019
@webknjaz webknjaz force-pushed the feature/22382-use-ssh-key-from-vault branch from 76fd65f to 5eb48b9 Compare March 8, 2019 15:09
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Mar 11, 2019
@webknjaz webknjaz force-pushed the feature/22382-use-ssh-key-from-vault branch from c4f8f1c to 0b46449 Compare March 11, 2019 15:21
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Mar 11, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Mar 15, 2019
@Aaron-von-Awesome
Copy link

Any updates on this? 😇

@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Oct 25, 2023
@webknjaz webknjaz requested a review from bcoca November 2, 2023 14:13
@kleberbaum
Copy link

I would love to see this feature implemented 😎 It would address the popular Feature Idea from 2017 #22382 and simplify many aspects of our work 👨‍💻👩‍💻 ty @webknjaz. @bcoca do you have any thoughts on this PR? What are its chances of being merged?

@bcoca
Copy link
Member

bcoca commented May 1, 2024

We probably will go this route #82181

@kleberbaum
Copy link

Can #22382 be reopened? @bcoca

@bcoca
Copy link
Member

bcoca commented May 1, 2024

no, as of now this is still not something we plan to support, both this PR and the one i reference is the core team exploring ways we could support this, not a commitment to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.8 This issue/PR affects Ansible v2.8 collection:amazon.aws collection:amazon.cloud collection:ansible.yang collection:arraynetworks.array_modules collection:chillancezen.fortianalyzer collection:chillancezen.fortimanager collection:cisco.fmcansible collection:community.aws collection:dimakis.rhosak_test collection:dominion_solutions.cloudflare collection:drmofu.fortianalyzer collection:dstanek.software collection:f5networks.f5_bigip collection:f5networks.f5_modules collection:f5networks.f5os collection:fortinet.fortianalyzer collection:grdavies.nutanix collection:ingatesystems.fuego_modules collection:jeichler.k8scoretest collection:kubernetes.core collection:lucasheld.uptime_kuma collection:micro14.stack collection:openafs_contrib.openafs collection:os_migrate.os_migrate collection:radware.alteon collection:rhoas.rhoas collection:sedi.openaudit collection:testing.k8s_demo_collection collection:yoctoalex.cloudservices collection:yoctoalex.xc_cloud_modules collection:zjleblanc.kasa collection Related to Ansible Collections work feature This issue/PR relates to a feature request. has_issue needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. pre_azp This PR was last tested before migration to Azure Pipelines. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow ssh private keys to be used that are encrypted with vault