Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netbox Inventory: Group By Platforms #52780

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@krisamundson
Copy link

krisamundson commented Feb 22, 2019

SUMMARY

Fixes the functionality group_by platforms. Adds the call to self.refresh_platforms_lookup and adds square brackets to return a list instead of a string.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

Netbox inventory plugin.

ADDITIONAL INFORMATION

@platforms_nxos is the output we're looking for with this change.

Before
@all:
  |--@device_roles_edge:
  |  |--n9k-inet01
  |  |--n9k-inet02
  |--@device_types_Nexus 93180YC-EX:
  |  |--n9k-inet01
  |  |--n9k-inet02
  |--@manufacturers_cisco:
  |  |--n9k-inet01
  |  |--n9k-inet02
  |--@racks_105:
  |  |--n9k-inet02
  |--@racks_106:
  |  |--n9k-inet01
  |--@sites_ABC:
  |  |--n9k-inet01
  |  |--n9k-inet02
  |--@tenants_customer1:
  |  |--n9k-inet01
  |  |--n9k-inet02
  |--@ungrouped:
  |  |-----
After
@all:
  |--@device_roles_edge:
  |  |--n9k-inet01
  |  |--n9k-inet02
  |--@device_types_Nexus 93180YC-EX:
  |  |--n9k-inet01
  |  |--n9k-inet02
  |--@manufacturers_cisco:
  |  |--n9k-inet01
  |  |--n9k-inet02
  |--@platforms_nxos:
  |  |--n9k-inet01
  |  |--n9k-inet02
  |--@racks_105:
  |  |--n9k-inet02
  |--@racks_106:
  |  |--n9k-inet01
  |--@sites_ABC:
  |  |--n9k-inet01
  |  |--n9k-inet02
  |--@tenants_customer1:
  |  |--n9k-inet01
  |  |--n9k-inet02
  |--@ungrouped:
  |  |-----
Netbox Inventory: Group By Platforms
Fixes the functionality to group_by 'platforms'. Adds the call to self.refresh_platforms_lookup
back and fixes square brackets to return a list instead of a string.
@ansibot

This comment has been minimized.

@FragmentedPacket

This comment has been minimized.

Copy link
Contributor

FragmentedPacket commented Feb 25, 2019

LGTM

@ansibot ansibot added the stale_ci label Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.