Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBIS (open) domain module #52799

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@stroobl
Copy link

stroobl commented Feb 22, 2019

SUMMARY

This module allows to join or leave an Active Directory domain with PBIS (open).
The module attempts to catch and fix a couple of common error scenario's when joining.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

pbis_domain

ADDITIONAL INFORMATION

The module was developed because joining with a simple command tasks caused so many half configured/broken states of the system.

Luc Stroobant
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 22, 2019

@AugustusKling @ColOfAbRiX @EvanK @LinusU @Mogztter @MorrisA @abulimov @adejoux @ahtik @Akasurde @azaghal @bgurney-rh @dankeder @davidobrien1985 @davixx @dirtyharrycallahan @dougluce @dsummersl @fishman @flynn1973 @gforster @giovannisciortino @goozbach @groks @haad @hryamzik @indrajitr @jasperla @jbenden @jdauphant @jhoekx @jpdasma @jsumners @jtyr @kairoaraujo @kevensen @kyleabenson @lberruti @marvin-sinister @mator @mattjeffery @matze @mcv21 @molekuul @mpdehaan @mulby @natefoo @nibalizer @obourdon @ovcharenko @pilou- @pmarkham @pyykkis @ramooncamacho @rhaido @risaacson @ryan_sb @saito-hideki @saranyasridharan @scathatheworm @sebastiendarocha @sfromm @srvg @tacatac @tdtrask @tmshn @troy2914 @wtcross @xen0l

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@denraf

denraf approved these changes Feb 27, 2019

join_options:
description:
- List of options for the join command.
- Refer to the PBIS documentation for all possible options.

This comment has been minimized.

@dagwieers

dagwieers Feb 27, 2019

Member

We recommend that modules do not have an option like this, but instead have parameters to enable all kind of functionality that influences the command line options. The reason for this is that in the future we can play around with parameters (rename them, make dependencies, migrate from one option to another) which is not possible with people's individual option lists.

Another problem is that people will add options or do things that this was not designed for, and that results in support questions (i.e. the module not being idempotent as a result, or not behaving as expected). Which in the end is end-user support for the command, rather than the module.

We have experienced issues like this before, so this comes with quite some legacy :-)

This comment has been minimized.

@stroobl

stroobl Mar 1, 2019

Author

Fair point, changed that.

Luc Stroobant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.