Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC connection plugin support to work with network os supporting gRPC #52823

Open
wants to merge 13 commits into
base: devel
from

Conversation

@ganeshrn
Copy link
Member

ganeshrn commented Feb 22, 2019

Fixes #38820

SUMMARY
  • This PR adds gRPC connection plugin.
  • Currently it uses ansible_network_os to load the correct
    gRPC implementation plugins (will be added in subsequent PR's).
    TODO: In future need to add support to work with non-network use case
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/plugins/connection/grpc.py

ADDITIONAL INFORMATION

@ganeshrn ganeshrn force-pushed the ganeshrn:grpc_connection_plugin branch 2 times, most recently from 326d7c7 to f2375ef Feb 23, 2019

@ganeshrn ganeshrn requested a review from samccann Feb 23, 2019

@ganeshrn ganeshrn force-pushed the ganeshrn:grpc_connection_plugin branch from f2375ef to 80a7169 Feb 26, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 26, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/kubevirt/kubevirt_template.py:0:0: E325 Argument 'resource_definition' in argument_spec defines type as <function list_dict_str at 0x7f292cd2bc80> but documentation defines type as 'str'

click here for bot help

@Qalthos

Qalthos approved these changes Mar 4, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 4, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/connection/grpc.py:261:34: E127 continuation line over-indented for visual indent

click here for bot help

@samccann
Copy link
Contributor

samccann left a comment

some docs nits :-)

Show resolved Hide resolved lib/ansible/plugins/connection/grpc.py Outdated
Show resolved Hide resolved lib/ansible/plugins/connection/grpc.py Outdated
Show resolved Hide resolved lib/ansible/plugins/connection/grpc.py Outdated
Show resolved Hide resolved lib/ansible/plugins/connection/grpc.py Outdated
Show resolved Hide resolved lib/ansible/plugins/connection/grpc.py Outdated
Show resolved Hide resolved lib/ansible/plugins/connection/grpc.py
Show resolved Hide resolved lib/ansible/plugins/connection/grpc.py Outdated
Show resolved Hide resolved lib/ansible/plugins/connection/grpc.py Outdated
Show resolved Hide resolved lib/ansible/plugins/connection/grpc.py Outdated
Show resolved Hide resolved lib/ansible/plugins/connection/grpc.py Outdated
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 5, 2019

@ganeshrn this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

ganeshrn and others added some commits Feb 22, 2019

Add gRPC connection plugin
Fixes #38820

* This PR adds gRPC connection plugin.
* Currently it uses `ansible_network_os` to load the correct
  gRPC implementation plugins (will be added in subsequent PR's).
  TODO: In future need to expand it to work with non-network use case
Update lib/ansible/plugins/connection/grpc.py
Add connection logs

Co-Authored-By: ganeshrn <ganesh634@gmail.com>
Update lib/ansible/plugins/connection/grpc.py
Co-Authored-By: ganeshrn <ganesh634@gmail.com>
Update lib/ansible/plugins/connection/grpc.py
Co-Authored-By: ganeshrn <ganesh634@gmail.com>
Update lib/ansible/plugins/connection/grpc.py
Co-Authored-By: ganeshrn <ganesh634@gmail.com>
Update lib/ansible/plugins/connection/grpc.py
Co-Authored-By: ganeshrn <ganesh634@gmail.com>
Update lib/ansible/plugins/connection/grpc.py
Co-Authored-By: ganeshrn <ganesh634@gmail.com>
Update lib/ansible/plugins/connection/grpc.py
Co-Authored-By: ganeshrn <ganesh634@gmail.com>
Update lib/ansible/plugins/connection/grpc.py
Co-Authored-By: ganeshrn <ganesh634@gmail.com>
Update lib/ansible/plugins/connection/grpc.py
Co-Authored-By: ganeshrn <ganesh634@gmail.com>
Update lib/ansible/plugins/connection/grpc.py
Co-Authored-By: ganeshrn <ganesh634@gmail.com>
Update lib/ansible/plugins/connection/grpc.py
Co-Authored-By: ganeshrn <ganesh634@gmail.com>

@ganeshrn ganeshrn force-pushed the ganeshrn:grpc_connection_plugin branch 2 times, most recently from e907f29 to 20b59e5 Mar 5, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 5, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/connection/grpc.py:262:34: E127 continuation line over-indented for visual indent

click here for bot help

Add gRPC connection plugin
Fixes #38820

* This PR adds gRPC connection plugin.
* Currently it uses `ansible_network_os` to load the correct
  gRPC implementation plugins (will be added in subsequent PR's).
  TODO: In future need to expand it to work with non-network use case

@ganeshrn ganeshrn force-pushed the ganeshrn:grpc_connection_plugin branch from 20b59e5 to 7818a6b Mar 5, 2019

@ansibot ansibot added core_review and removed needs_revision labels Mar 5, 2019

@ansibot ansibot added the stale_ci label Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.