Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for dnf versionlock plugin init failure #52859

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@maxamillion
Copy link
Contributor

maxamillion commented Feb 22, 2019

SUMMARY

This patch will no longer be necessary once a future version of dnf
is released that includes the patch I submitted upstream[0], but in
the meantime this is a regression in functionality for Ansible
users. Also, since it's all encapsulated in an exception handler, it
shouldn't have any impact otherwise.

Fixes #50237

[0] - rpm-software-management/dnf-plugins-core#317

Signed-off-by: Adam Miller admiller@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

dnf

Add workaround for dnf versionlock plugin init failure
This patch will no longer be necessary once a future version of dnf
is released that includes the patch I submitted upstream[0], but in
the meantime this is a regression in functionality for Ansible
users. Also, since it's all encapsulated in an exception handler, it
shouldn't have any impact otherwise.

Fixes #50237

[0] - rpm-software-management/dnf-plugins-core#317

Signed-off-by: Adam Miller <admiller@redhat.com>
@ansibot

This comment has been minimized.

@gundalow
Copy link
Contributor

gundalow left a comment

Not tested though code makes sense to o my limited understanding of DNF.
Changelog would be good once others have reviewed.

Any potential downside of disabling versionlock?

Show resolved Hide resolved lib/ansible/modules/packaging/os/dnf.py
self.module.warn("Disabling dnf versionlock plugin due do known upstream bug: "
"https://github.com/rpm-software-management/dnf-plugins-core/pull/317")
self.disable_plugin.append('versionlock')
broken_plugin_found = True

This comment has been minimized.

@gundalow

gundalow Feb 22, 2019

Contributor

Where is broken_plugin_found used?

This comment has been minimized.

@maxamillion

maxamillion Feb 22, 2019

Author Contributor

It's not, I forgot to remove that. I was toying with a different implementation but this ended up being less invasive.

add changelog, remove unnecessary bool
Signed-off-by: Adam Miller <admiller@redhat.com>
make sanity checks happy
Signed-off-by: Adam Miller <admiller@redhat.com>

@ansibot ansibot added the stale_ci label Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.