Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the functionlity to address the shard_group_duration. #52921

Open
wants to merge 6 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@theo-bot
Copy link

theo-bot commented Feb 25, 2019

SUMMARY

Added the functionality add a shard_group_duration in a retentention policy

Fixes #44771

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Module: influxdb_retention_policy

ADDITIONAL INFORMATION

A retention policy includes a shard_group_duration. This impacts the amount of data that is removed after the data has reached its expiration date. With this request this can be configured as well.

https://docs.influxdata.com/influxdb/v1.7/query_language/database_management/#retention-policy-management


@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 25, 2019

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/database/influxdb/influxdb_retention_policy.py:133:101: bad-whitespace Exactly one space required after comma             client.create_retention_policy(policy_name, duration, replication, database_name, default,shard_group_duration)                                                                                                      ^
lib/ansible/modules/database/influxdb/influxdb_retention_policy.py:169:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/database/influxdb/influxdb_retention_policy.py:211:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/database/influxdb/influxdb_retention_policy.py:133:102: E231 missing whitespace after ','
lib/ansible/modules/database/influxdb/influxdb_retention_policy.py:169:1: W293 blank line contains whitespace
lib/ansible/modules/database/influxdb/influxdb_retention_policy.py:211:1: W391 blank line at end of file

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/database/influxdb/influxdb_retention_policy.py:0:0: E322 Argument 'shard_duration' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/database/influxdb/influxdb_retention_policy.py:210:0: E109 Next to last line should be: if __name__ == "__main__":

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 25, 2019

@theo-bot

This comment has been minimized.

Copy link
Author

theo-bot commented Feb 25, 2019

ready_for_review

@ansibot ansibot removed the ci_verified label Feb 25, 2019

Theo Bot
@theo-bot

This comment has been minimized.

Copy link
Author

theo-bot commented Feb 25, 2019

ready_for_review

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 25, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/database/influxdb/influxdb_retention_policy.py:173:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/database/influxdb/influxdb_retention_policy.py:173:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/database/influxdb/influxdb_retention_policy.py:0:0: E309 version_added for new option (shard_duration) should be '2.8'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot ansibot added the ci_verified label Feb 25, 2019

Theo Bot
@theo-bot

This comment has been minimized.

Copy link
Author

theo-bot commented Feb 25, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/database/influxdb/influxdb_retention_policy.py:173:0: trailing-whitespace Trailing whitespace <-- Not true

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/database/influxdb/influxdb_retention_policy.py:173:1: W293 blank line contains whitespace <-- Not true

How to fix : ERROR: lib/ansible/modules/database/influxdb/influxdb_retention_policy.py:0:0: E309 version_added for new option (shard_duration) should be '2.8'. Currently StrictVersion ('0.0') (75%)

@ansibot ansibot added the bot_broken label Feb 25, 2019

Theo Bot
@theo-bot

This comment has been minimized.

Copy link
Author

theo-bot commented Feb 26, 2019

ready_for_review

Theo Bot
@theo-bot

This comment has been minimized.

Copy link
Author

theo-bot commented Feb 26, 2019

ready_for_review

1 similar comment
@theo-bot

This comment has been minimized.

Copy link
Author

theo-bot commented Mar 2, 2019

ready_for_review

@ushuz

This comment has been minimized.

Copy link
Contributor

ushuz commented Mar 10, 2019

This is the correct issue: #44711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.